Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 781743002: Deleted unused code about WebViewImpl::getSelectionRootBounds (Closed)

Created:
6 years ago by Byoungkwon Ko
Modified:
6 years ago
Reviewers:
pdr., adamk, pfeldman
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Deleted unused code about WebViewImpl::getSelectionRootBounds WebViewImpl::getSelectionRootBounds function was called by RenderViewImpl::GetSelectionRootBounds. But nowdays anything don't call the function, so this code is dead code. I deleted some html file and modified some source code. BUG=438128 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186653

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -242 lines) Patch
M Source/web/WebViewImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +0 lines, -29 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 1 chunk +1 line, -74 lines 0 comments Download
D Source/web/tests/data/select_range_basic_broken_height.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_div_editable.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_input.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_input_overflow.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_scroll.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_span_editable.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_textarea.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_iframe_textarea_overflow.html View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/web/tests/data/select_range_input.html View 1 chunk +0 lines, -11 lines 0 comments Download
D Source/web/tests/data/select_range_input_overflow.html View 1 chunk +0 lines, -11 lines 0 comments Download
D Source/web/tests/data/select_range_textarea.html View 1 chunk +0 lines, -11 lines 0 comments Download
D Source/web/tests/data/select_range_textarea_overflow.html View 1 chunk +0 lines, -13 lines 0 comments Download
M public/web/WebView.h View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Byoungkwon Ko
On 2014/12/04 15:52:40, Byoungkwon Ko wrote: > mailto:gogag2@gmail.com changed reviewers: > + mailto:pdr@chromium.org, mailto:zino@chromium.org Could ...
6 years ago (2014-12-04 15:53:34 UTC) #4
pdr.
Nice! Just some minor comments below. I'll kick off some tryjob runs for you as ...
6 years ago (2014-12-04 19:01:59 UTC) #5
Byoungkwon Ko
Thanks for your kind review. I modified WebViewTest.cpp and deleted select_range_basic_broken_height.html Could you review for ...
6 years ago (2014-12-07 15:36:18 UTC) #6
pdr.
LGTM. We'll need to wait for a Source/web owner for the final OK. Adam or ...
6 years ago (2014-12-07 21:52:35 UTC) #8
pfeldman
lgtm.
6 years ago (2014-12-07 23:52:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781743002/20001
6 years ago (2014-12-07 23:54:59 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-08 01:27:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186653

Powered by Google App Engine
This is Rietveld 408576698