Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/clang/plugins/tests/missing_ctor.txt

Issue 952893003: Update from https://crrev.com/317530 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix gn for nacl Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/missing_ctor.h ('k') | tools/clang/plugins/tests/overridden_methods.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/missing_ctor.txt
diff --git a/tools/clang/plugins/tests/missing_ctor.txt b/tools/clang/plugins/tests/missing_ctor.txt
index 301449c4ac2194a4a14e4d0930ec6484b09654aa..0bc5696be6409f40916ed86f1465b759fcf1a10f 100644
--- a/tools/clang/plugins/tests/missing_ctor.txt
+++ b/tools/clang/plugins/tests/missing_ctor.txt
@@ -1,6 +1,15 @@
In file included from missing_ctor.cpp:5:
-./missing_ctor.h:11:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
+./missing_ctor.h:13:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
class MissingCtorsArentOKInHeader {
^
-./missing_ctor.h:11:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
-2 warnings generated.
+./missing_ctor.h:13:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
+./missing_ctor.h:39:3: warning: [chromium-style] Complex constructor has an inlined body.
+ ExplicitlyDefaultedInlineAlsoWarns() = default;
+ ^
+./missing_ctor.h:41:3: warning: [chromium-style] Complex constructor has an inlined body.
+ ExplicitlyDefaultedInlineAlsoWarns(
+ ^
+./missing_ctor.h:40:3: warning: [chromium-style] Complex destructor has an inline body.
+ ~ExplicitlyDefaultedInlineAlsoWarns() = default;
+ ^
+5 warnings generated.
« no previous file with comments | « tools/clang/plugins/tests/missing_ctor.h ('k') | tools/clang/plugins/tests/overridden_methods.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698