tools/clang/plugins/tests/missing_ctor.txt - Issue 952893003: Update from https://crrev.com/317530

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/missing_ctor.txt

Issue 952893003: Update from https://crrev.com/317530 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix gn for nacl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 In file included from missing_ctor.cpp:5:	1 In file included from missing_ctor.cpp:5:

2 ./missing_ctor.h:11:1: warning: [chromium-style] Complex class/struct needs an e xplicit out-of-line constructor.	2 ./missing_ctor.h:13:1: warning: [chromium-style] Complex class/struct needs an e xplicit out-of-line constructor.

3 class MissingCtorsArentOKInHeader {	3 class MissingCtorsArentOKInHeader {

4 ^	4 ^

5 ./missing_ctor.h:11:1: warning: [chromium-style] Complex class/struct needs an e xplicit out-of-line destructor.	5 ./missing_ctor.h:13:1: warning: [chromium-style] Complex class/struct needs an e xplicit out-of-line destructor.

6 2 warnings generated.	6 ./missing_ctor.h:39:3: warning: [chromium-style] Complex constructor has an inli ned body.

	7 ExplicitlyDefaultedInlineAlsoWarns() = default;

	8 ^

	9 ./missing_ctor.h:41:3: warning: [chromium-style] Complex constructor has an inli ned body.

	10 ExplicitlyDefaultedInlineAlsoWarns(

	11 ^

	12 ./missing_ctor.h:40:3: warning: [chromium-style] Complex destructor has an inlin e body.

	13 ~ExplicitlyDefaultedInlineAlsoWarns() = default;

	14 ^

	15 5 warnings generated.

OLD	NEW