masters/master.client.v8.branches/master.cfg - Issue 952653003: Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by def…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: masters/master.client.v8.branches/master.cfg

Issue 952653003: Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by def… (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« masters/master.chromium.lkgr/master_lkgr_cfg.py ('K') | « masters/master.chromium.lkgr/master_lkgr_cfg.py ('k') | scripts/slave/recipe_modules/chromium/client_v8_branches.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: masters/master.client.v8.branches/master.cfg

diff --git a/masters/master.client.v8.branches/master.cfg b/masters/master.client.v8.branches/master.cfg

index 9b58b9a240c632b32f4affe5cbdbf3e9c88ecac6..e0ff771e5e35452b32a8b02f7c12184dd736a412 100644

--- a/masters/master.client.v8.branches/master.cfg

+++ b/masters/master.client.v8.branches/master.cfg

@@ -141,10 +141,10 @@ linux_default_opts = ['--build-tool=make', '--src-dir=v8',

# the stable branch.

'--', 'builddir_name=.']

-asan_rel_sym_gyp = ('asan=1 use_allocator=none v8_enable_verify_heap=1 '

+asan_rel_sym_gyp = ('asan=1 lsan=1 sanitizer_coverage=3 '

earthdok 2015/02/24 16:46:14 The following options are redundant: use_allocato

+ 'use_allocator=none v8_enable_verify_heap=1 '

'release_extra_cflags="-gline-tables-only '

- '-O2 -fno-inline-functions -fno-inline" '

- 'lsan=1 asan_coverage=1')

+ '-O2 -fno-inline-functions -fno-inline" ')

f_linux_asan_rel_sym = linux().ChromiumFactory(

clobber=True,

@@ -174,7 +174,7 @@ f_linux_asan_dbg = linux().ChromiumFactory(

'gs_bucket': 'gs://v8-asan',

'gs_acl': 'public-read',

'gclient_env': {

- 'GYP_DEFINES': ('asan=1 lsan=1 asan_coverage=1 '

+ 'GYP_DEFINES': ('asan=1 lsan=1 sanitizer_coverage=3 '

'use_allocator=none v8_optimized_debug=1'),

'no_gclient_revision': True,

@@ -182,7 +182,8 @@ f_linux_asan_dbg = linux().ChromiumFactory(

'safesync_url': 'http://chromium-status.appspot.com/lkgr',

})

-asan_x64_v8_arm64 = ('asan=1 asan_coverage=1 use_allocator=none disable_nacl=1 '

+asan_x64_v8_arm64 = ('asan=1 lsan=1 sanitizer_coverage=3 '

earthdok 2015/02/24 16:46:14 Same as above. Also, why disable_nacl=1 here?

+ 'use_allocator=none disable_nacl=1 '

'v8_target_arch=arm64 host_arch=x86_64 target_arch=x64 '

'v8_enable_verify_heap=1 enable_ipc_fuzzer=1')

asan_x64_v8_arm64_rel_sym = ('%s release_extra_cflags="-gline-tables-only -O1 '