Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by def…

masters/master.client.v8.branches/master.cfg

 # -*- python -*-
 # ex: set syntax=python:
 
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildbot.changes.filter import ChangeFilter
 from buildbot.scheduler import Nightly
 from buildbot.scheduler import Scheduler
@@ skipping 123 matching lines @@
     })
 
 # The identifier of the factory is the build configuration. If two factories
 # are using the same build configuration, they should have the same identifier.
 
 linux_default_opts = ['--build-tool=make', '--src-dir=v8',
                       # TODO(thakis): Remove this once v8 r18257 has reached
                       # the stable branch.
                       '--', 'builddir_name=.']
 
-asan_rel_sym_gyp = ('asan=1 use_allocator=none v8_enable_verify_heap=1 '
+asan_rel_sym_gyp = ('asan=1 lsan=1 sanitizer_coverage=3 '

[earthdok, 2015/02/24 16:46:14]

The following options are redundant:

use_allocator=none release_extra_cflags="-gline_tables-only -O2"

+                    'use_allocator=none v8_enable_verify_heap=1 '
                     'release_extra_cflags="-gline-tables-only '
-                    '-O2 -fno-inline-functions -fno-inline" '
-                    'lsan=1 asan_coverage=1')
+                    '-O2 -fno-inline-functions -fno-inline" ')
 
 f_linux_asan_rel_sym = linux().ChromiumFactory(
     clobber=True,
     options=['--compiler=goma-clang', 'chromium_builder_asan'],
     factory_properties={
         'primary_repo': 'v8_',
         'cf_archive_build': ActiveMaster.is_production_host,
         'cf_archive_name': 'asan-symbolized',
         'gs_bucket': 'gs://v8-asan',
         'gs_acl': 'public-read',
         'gclient_env': {
             'GYP_DEFINES': asan_rel_sym_gyp,
         },
         'no_gclient_revision': True,
         'revision_dir': 'v8',
         'safesync_url': 'http://chromium-status.appspot.com/lkgr',
     })
 
 f_linux_asan_dbg = linux().ChromiumFactory(
     target='Debug',
     clobber=True,
     options=['--compiler=goma-clang', 'chromium_builder_asan'],
     factory_properties={
         'primary_repo': 'v8_',
         'cf_archive_build': ActiveMaster.is_production_host,
         'cf_archive_name': 'asan',
         'gs_bucket': 'gs://v8-asan',
         'gs_acl': 'public-read',
         'gclient_env': {
-            'GYP_DEFINES': ('asan=1 lsan=1 asan_coverage=1 '
+            'GYP_DEFINES': ('asan=1 lsan=1 sanitizer_coverage=3 '
                             'use_allocator=none v8_optimized_debug=1'),
         },
         'no_gclient_revision': True,
         'revision_dir': 'v8',
         'safesync_url': 'http://chromium-status.appspot.com/lkgr',
     })
 
-asan_x64_v8_arm64 = ('asan=1 asan_coverage=1 use_allocator=none disable_nacl=1 '
+asan_x64_v8_arm64 = ('asan=1 lsan=1 sanitizer_coverage=3 '

[earthdok, 2015/02/24 16:46:14]

Same as above. Also, why disable_nacl=1 here?

+                     'use_allocator=none disable_nacl=1 '
                      'v8_target_arch=arm64 host_arch=x86_64 target_arch=x64 '
                      'v8_enable_verify_heap=1 enable_ipc_fuzzer=1')
 asan_x64_v8_arm64_rel_sym = ('%s release_extra_cflags="-gline-tables-only -O1 '
                              '-fno-inline-functions -fno-inline"' %
                              asan_x64_v8_arm64)
 
 f_linux_asan_arm64_rel_sym = linux().ChromiumFactory(
     clobber=True,
     options=['--compiler=goma-clang', 'chromium_builder_asan'],
     factory_properties={
@@ skipping 308 matching lines @@
                     lookup=master_utils.FilterDomain())
   c['status'].append(mn)
 
 # Adjust the buildCaches to be 3x the number of slaves per builder.
 c['autoBuildCacheRatio'] = 3
 
 ####### PROJECT IDENTITY
 
 c['projectName'] = ActiveMaster.project_name
 c['projectURL'] = config.Master.project_url