masters/master.chromium.lkgr/master_lkgr_cfg.py - Issue 952653003: Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by def…

Unified Diff: masters/master.chromium.lkgr/master_lkgr_cfg.py

Issue 952653003: Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by def… (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: masters/master.chromium.lkgr/master_lkgr_cfg.py

diff --git a/masters/master.chromium.lkgr/master_lkgr_cfg.py b/masters/master.chromium.lkgr/master_lkgr_cfg.py

index d5f4a6753ff2f670767080d2cbdc05da4048c275..8b71354a30c3b7435ebafffafc580c686ecbd6dd 100644

--- a/masters/master.chromium.lkgr/master_lkgr_cfg.py

+++ b/masters/master.chromium.lkgr/master_lkgr_cfg.py

@@ -92,6 +92,8 @@ F('mac_full', mac().ChromiumFactory(

'gs_bucket': 'gs://chromium-browser-continuous',

'gs_acl': 'public-read',}))

+mac_asan_rel_gyp = ('asan=1 enable_ipc_fuzzer=1 v8_enable_verify_heap=1 ')

earthdok 2015/02/24 16:46:14 You're making a functional change (v8_enable_verif

B('Mac ASAN Release', 'mac_asan_rel', 'compile', 'chromium_lkgr')

F('mac_asan_rel', linux().ChromiumASANFactory(

clobber=True,

@@ -101,7 +103,9 @@ F('mac_asan_rel', linux().ChromiumASANFactory(

'cf_archive_name': 'asan',

'gs_bucket': 'gs://chromium-browser-asan',

'gs_acl': 'public-read',

- 'gclient_env': {'GYP_DEFINES': 'asan=1 '}}))

+ 'gclient_env': {'GYP_DEFINES': mac_asan_rel_gyp}}))

+mac_asan_debug_gyp = ('asan=1 component=static_library enable_ipc_fuzzer=1 ')

earthdok 2015/02/24 16:46:14 As a side note, it would be nice to have a comment

B('Mac ASAN Debug', 'mac_asan_dbg', 'compile', 'chromium_lkgr')

F('mac_asan_dbg', linux().ChromiumASANFactory(

@@ -113,7 +117,7 @@ F('mac_asan_dbg', linux().ChromiumASANFactory(

'cf_archive_name': 'asan',

'gs_bucket': 'gs://chromium-browser-asan',

'gs_acl': 'public-read',

- 'gclient_env': {'GYP_DEFINES': 'asan=1 component=static_library '}}))

+ 'gclient_env': {'GYP_DEFINES': mac_asan_debug_gyp}}))

################################################################################

## Linux

@@ -135,8 +139,8 @@ F('linux64_full', linux().ChromiumFactory(

'gs_acl': 'public-read',

'gclient_env': {'GYP_DEFINES':'target_arch=x64'}}))

-asan_rel_gyp = ('asan=1 lsan=1 asan_coverage=1 '

- 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1 ')

+asan_rel_gyp = ('asan=1 lsan=1 sanitizer_coverage=3 '

+ 'enable_ipc_fuzzer=1 v8_enable_verify_heap=1 ')

B('ASAN Release', 'linux_asan_rel', 'compile', 'chromium_lkgr')

F('linux_asan_rel', linux().ChromiumASANFactory(

@@ -150,8 +154,8 @@ F('linux_asan_rel', linux().ChromiumASANFactory(

'gs_acl': 'public-read',

'gclient_env': {'GYP_DEFINES': asan_rel_gyp}}))

-asan_rel_sym_gyp = ('asan=1 lsan=1 asan_coverage=1 '

- 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1 '

+asan_rel_sym_gyp = ('asan=1 lsan=1 sanitizer_coverage=3 '

+ 'enable_ipc_fuzzer=1 v8_enable_verify_heap=1 '

'release_extra_cflags="-O1 -fno-inline-functions '

'-fno-inline" ')

@@ -166,7 +170,7 @@ F('linux_asan_rel_sym', linux().ChromiumASANFactory(

'gs_acl': 'public-read',

'gclient_env': {'GYP_DEFINES': asan_rel_sym_gyp}}))

-asan_debug_gyp = ('asan=1 lsan=1 asan_coverage=1 enable_ipc_fuzzer=1')

+asan_debug_gyp = ('asan=1 lsan=1 sanitizer_coverage=3 enable_ipc_fuzzer=1 ')

B('ASAN Debug', 'linux_asan_dbg', 'compile', 'chromium_lkgr')

F('linux_asan_dbg', linux().ChromiumASANFactory(

@@ -196,10 +200,10 @@ F('linux_chromiumos_asan_rel', linux().ChromiumASANFactory(

'gs_acl': 'public-read',

'gclient_env': {'GYP_DEFINES': asan_chromiumos_rel_gyp}}))

-asan_ia32_v8_arm = ('asan=1 asan_coverage=1 disable_nacl=1 '

+asan_ia32_v8_arm = ('asan=1 sanitizer_coverage=3 disable_nacl=1 '

'v8_target_arch=arm host_arch=x86_64 target_arch=ia32 '

'sysroot=/var/lib/chroot/precise32bit chroot_cmd=precise32 '

- 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1')

+ 'v8_enable_verify_heap=1 enable_ipc_fuzzer=1 ')

asan_ia32_v8_arm_rel_sym = ('%s release_extra_cflags="-O1 '

'-fno-inline-functions -fno-inline"' %

@@ -283,8 +287,8 @@ F('linux_tsan_dbg', linux().ChromiumFactory(

# The build process for MSan is described at

# http://dev.chromium.org/developers/testing/memorysanitizer

-msan_gyp = ('msan=1 use_instrumented_libraries=1 '

- 'instrumented_libraries_jobs=5 ')

+msan_gyp = ('msan=1 sanitizer_coverage=3 '

+ 'use_instrumented_libraries=1 instrumented_libraries_jobs=5 ')

B('MSAN Release (no origins)', 'linux_msan_rel_no_origins', 'compile',

'chromium_lkgr')

@@ -319,7 +323,7 @@ F('telemetry_harness_upload',

# The build process for UBSan vptr is described at

# http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer

-ubsan_gyp = ('ubsan=1')

+ubsan_gyp = ('ubsan=1 sanitizer_coverage=3 ')

B('UBSan Release', 'linux_ubsan_rel', 'compile', 'chromium_lkgr')

F('linux_ubsan_rel', linux().ChromiumFactory(

@@ -333,7 +337,7 @@ F('linux_ubsan_rel', linux().ChromiumFactory(

'gs_acl': 'public-read',

'gclient_env': {'GYP_DEFINES': ubsan_gyp}}))

-ubsan_vptr_gyp = ('ubsan_vptr=1')

+ubsan_vptr_gyp = ('ubsan_vptr=1 sanitizer_coverage=3 ')

B('UBSan vptr Release', 'linux_ubsan_vptr_rel', 'compile', 'chromium_lkgr')

F('linux_ubsan_vptr_rel', linux().ChromiumFactory(

« no previous file with comments | « no previous file | masters/master.client.v8.branches/master.cfg » ('j') | masters/master.client.v8.branches/master.cfg » ('J')