Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by def…

Change asan_coverage(deprecated) flag to sanitizer_coverage. Enable edge-level code coverage by default across ASAN, MSAN, UBSAN.

Internal expectations: https://chromereviews.googleplex.com/162707013/

BUG=444896
TBR=jam@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294201

[inferno, 2015-02-23 18:58:22]

inferno@chromium.org changed reviewers:
+ glider@chromium.org, jam@chromium.org

[earthdok, 2015-02-24 16:46:13]

earthdok@chromium.org changed reviewers:
+ earthdok@chromium.org

[earthdok, 2015-02-24 16:46:14]

https://codereview.chromium.org/952653003/diff/1/masters/master.chromium.lkgr...
File masters/master.chromium.lkgr/master_lkgr_cfg.py (right):

https://codereview.chromium.org/952653003/diff/1/masters/master.chromium.lkgr...
masters/master.chromium.lkgr/master_lkgr_cfg.py:95: mac_asan_rel_gyp = ('asan=1
enable_ipc_fuzzer=1 v8_enable_verify_heap=1 ')
You're making a functional change (v8_enable_verify_heap=1) which is not related
to the CL.

https://codereview.chromium.org/952653003/diff/1/masters/master.chromium.lkgr...
masters/master.chromium.lkgr/master_lkgr_cfg.py:108: mac_asan_debug_gyp =
('asan=1 component=static_library enable_ipc_fuzzer=1 ')
As a side note, it would be nice to have a comment explaining why debug requires
component=static_library.

https://codereview.chromium.org/952653003/diff/1/masters/master.client.v8.bra...
File masters/master.client.v8.branches/master.cfg (right):

https://codereview.chromium.org/952653003/diff/1/masters/master.client.v8.bra...
masters/master.client.v8.branches/master.cfg:144: asan_rel_sym_gyp = ('asan=1
lsan=1 sanitizer_coverage=3 '
The following options are redundant:

use_allocator=none release_extra_cflags="-gline_tables-only -O2"

https://codereview.chromium.org/952653003/diff/1/masters/master.client.v8.bra...
masters/master.client.v8.branches/master.cfg:185: asan_x64_v8_arm64 = ('asan=1
lsan=1 sanitizer_coverage=3 '
Same as above. Also, why disable_nacl=1 here?

[inferno, 2015-02-24 17:09:01]

On 2015/02/24 16:46:14, earthdok wrote:
>
https://codereview.chromium.org/952653003/diff/1/masters/master.chromium.lkgr...
> File masters/master.chromium.lkgr/master_lkgr_cfg.py (right):
> 
>
https://codereview.chromium.org/952653003/diff/1/masters/master.chromium.lkgr...
> masters/master.chromium.lkgr/master_lkgr_cfg.py:95: mac_asan_rel_gyp =
('asan=1
> enable_ipc_fuzzer=1 v8_enable_verify_heap=1 ')
> You're making a functional change (v8_enable_verify_heap=1) which is not
related
> to the CL.

Yes removed. will enable ipc fuzzer on mac in seperate cl.

> 
>
https://codereview.chromium.org/952653003/diff/1/masters/master.chromium.lkgr...
> masters/master.chromium.lkgr/master_lkgr_cfg.py:108: mac_asan_debug_gyp =
> ('asan=1 component=static_library enable_ipc_fuzzer=1 ')
> As a side note, it would be nice to have a comment explaining why debug
requires
> component=static_library.

Yes removed. will enable ipc fuzzer on mac in seperate cl.

> 
>
https://codereview.chromium.org/952653003/diff/1/masters/master.client.v8.bra...
> File masters/master.client.v8.branches/master.cfg (right):
> 
>
https://codereview.chromium.org/952653003/diff/1/masters/master.client.v8.bra...
> masters/master.client.v8.branches/master.cfg:144: asan_rel_sym_gyp = ('asan=1
> lsan=1 sanitizer_coverage=3 '
> The following options are redundant:
> 
> use_allocator=none release_extra_cflags="-gline_tables-only -O2"

removed.

> 
>
https://codereview.chromium.org/952653003/diff/1/masters/master.client.v8.bra...
> masters/master.client.v8.branches/master.cfg:185: asan_x64_v8_arm64 = ('asan=1
> lsan=1 sanitizer_coverage=3 '
> Same as above. Also, why disable_nacl=1 here?

removed. don't know why disable_nacl is needed. it is also enabled on 32-bit arm
linux asan arm builds. so will leave it as it is for now.
https://code.google.com/p/chromium/codesearch#chromium/build/masters/master.c...

[earthdok, 2015-02-24 17:13:05]

lgtm w/nit

https://codereview.chromium.org/952653003/diff/20001/masters/master.client.v8...
File masters/master.client.v8.branches/master.cfg (right):

https://codereview.chromium.org/952653003/diff/20001/masters/master.client.v8...
masters/master.client.v8.branches/master.cfg:177: 'use_allocator=none
v8_optimized_debug=1'),
Please remove use_allocator=none here as well.

[inferno, 2015-02-24 17:15:12]

The CQ bit was checked by inferno@chromium.org

[inferno, 2015-02-24 17:15:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
earthdok@chromium.org
Link to the patchset: https://codereview.chromium.org/952653003/#ps40001 (title:
"remove another use_allocator=none")

[inferno, 2015-02-24 17:15:17]

On 2015/02/24 17:13:05, earthdok wrote:
> lgtm w/nit
> 
>
https://codereview.chromium.org/952653003/diff/20001/masters/master.client.v8...
> File masters/master.client.v8.branches/master.cfg (right):
> 
>
https://codereview.chromium.org/952653003/diff/20001/masters/master.client.v8...
> masters/master.client.v8.branches/master.cfg:177: 'use_allocator=none
> v8_optimized_debug=1'),
> Please remove use_allocator=none here as well.

Done!

[commit-bot: I haz the power, 2015-02-24 17:17:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952653003/40001

[commit-bot: I haz the power, 2015-02-24 17:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 17:20:41]

Presubmit check for 952653003-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
scripts/slave/unittests/recipe_simulation_test.py (33.48s) failed
.......................................................................................................................................................................................................................................................F................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

======================================================================
FAIL: chromium.full_client_v8_branches_Chromium_ASAN__symbolized_
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium.expected/full_client_v8_branches_Chromium_ASAN__symbolized_.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 51,59 ****
                             
'@@@SET_BUILD_PROPERTY@got_revision_cp@"refs/heads/master@{#43426}"@@@',
                             
'@@@SET_BUILD_PROPERTY@got_swarming_client_revision_cp@"refs/heads/master@{#276089}"@@@',
                             
'@@@SET_BUILD_PROPERTY@got_webrtc_revision_cp@"refs/heads/master@{#120644}"@@@']},
   {'cmd': ['python', '-u', '[DEPOT_TOOLS]/gclient.py', 'runhooks'],
!   'env': {'GYP_DEFINES': "asan=1 sanitizer_coverage=3 clang=1
component=static_library gomadir='[BUILD]/goma' lsan=1
release_extra_cflags='-gline-tables-only -O2 -fno-inline-functions -fno-inline'
target_arch=x64 use_allocator=none use_goma=1 v8_enable_verify_heap=1"},
    'name': 'gclient runhooks'},
   {'cmd': ['python', '-u', '[BUILD]/scripts/slave/cleanup_temp.py'],
    'name': 'cleanup_temp'},
   {'cmd': ['python',
--- 51,59 ----
                             
'@@@SET_BUILD_PROPERTY@got_revision_cp@"refs/heads/master@{#43426}"@@@',
                             
'@@@SET_BUILD_PROPERTY@got_swarming_client_revision_cp@"refs/heads/master@{#276089}"@@@',
                             
'@@@SET_BUILD_PROPERTY@got_webrtc_revision_cp@"refs/heads/master@{#120644}"@@@']},
   {'cmd': ['python', '-u', '[DEPOT_TOOLS]/gclient.py', 'runhooks'],
!   'env': {'GYP_DEFINES': "asan=1 clang=1 component=static_library
gomadir='[BUILD]/goma' lsan=1 release_extra_cflags='-gline-tables-only -O2
-fno-inline-functions -fno-inline' sanitizer_coverage=3 target_arch=x64
use_allocator=none use_goma=1 v8_enable_verify_heap=1"},
    'name': 'gclient runhooks'},
   {'cmd': ['python', '-u', '[BUILD]/scripts/slave/cleanup_temp.py'],
    'name': 'cleanup_temp'},
   {'cmd': ['python',


----------------------------------------------------------------------
Ran 1208 tests in 26.449s

FAILED (failures=1)


Presubmit checks took 163.5s to calculate.

[earthdok, 2015-02-24 17:28:30]

You need to update the expectations:

scripts/slave/unittests/recipe_simulation_test.py train

[inferno, 2015-02-24 17:48:46]

The CQ bit was checked by inferno@chromium.org

[inferno, 2015-02-24 17:48:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
earthdok@chromium.org
Link to the patchset: https://codereview.chromium.org/952653003/#ps60001 (title:
"rebase with recipe_simulation_test.py")

[inferno, 2015-02-24 17:49:00]

On 2015/02/24 17:28:30, earthdok wrote:
> You need to update the expectations:
> 
> scripts/slave/unittests/recipe_simulation_test.py train

Done!

[commit-bot: I haz the power, 2015-02-24 17:49:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952653003/60001

[commit-bot: I haz the power, 2015-02-24 17:52:34]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294201