Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 952563003: Reinstate the error code to main content area + bug fixes on security / network interstitials (Closed)

Created:
5 years, 10 months ago by edwardjung
Modified:
5 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Error code: + Reinstate the error code to main content as important for debugging when screen shots are sent + Remove the 'Error code:' prefix on the net error for consistency. Fixes related to browsing scaling: + Remove fixed button height to fix cropped button + Fix to incorrectly scaled T-rex Design: + Make the faint tick in checkbox have 0 opacity + Fix cropped padlock icon BUG=460116, 459510, 459126, 458484 Committed: https://crrev.com/b907b0c9264e74fa890318a36bbbe947badda192 Cr-Commit-Position: refs/heads/master@{#318712}

Patch Set 1 #

Patch Set 2 : Adjust error code margins #

Patch Set 3 : #

Patch Set 4 : Offline interstitial tweaks for mobile #

Patch Set 5 : Move error code to the main content area. #

Patch Set 6 : Update the safe browsing blocking page browser tests #

Patch Set 7 : Fix safe browsing tests, secondary button adjustments for windows #

Patch Set 8 : Adjust vertical alignment of details button, remove net error string prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -41 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/security_warnings/images/1x/brokenssl_red.png View Binary file 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.css View 1 2 3 4 5 6 7 9 chunks +33 lines, -18 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/resources/neterror.css View 1 2 3 4 5 6 7 4 chunks +19 lines, -13 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/resources/neterror.js View 1 2 3 4 5 6 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/resources/offline.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
edwardjung
Hi Erik, Please take a look. Thanks. Edward
5 years, 10 months ago (2015-02-24 22:34:10 UTC) #2
edwardjung
James, could you have a look at: - chrome/app/generated_resources.grd - chrome/browser/errorpage_browsertest.cc Erik you're good to ...
5 years, 9 months ago (2015-02-27 12:55:12 UTC) #4
arv (Not doing code reviews)
LGTM
5 years, 9 months ago (2015-02-27 14:17:59 UTC) #5
James Hawkins
lgtm
5 years, 9 months ago (2015-02-27 15:27:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952563003/140001
5 years, 9 months ago (2015-03-02 17:05:16 UTC) #8
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 9 months ago (2015-03-02 17:08:45 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:09:39 UTC) #10
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/b907b0c9264e74fa890318a36bbbe947badda192
Cr-Commit-Position: refs/heads/master@{#318712}

Powered by Google App Engine
This is Rietveld 408576698