chrome/renderer/resources/neterror.js - Issue 952563003: Reinstate the error code to main content area + bug fixes on security / network interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/neterror.js

Issue 952563003: Reinstate the error code to main content area + bug fixes on security / network interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust vertical alignment of details button, remove net error string prefix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/neterror.js

diff --git a/chrome/renderer/resources/neterror.js b/chrome/renderer/resources/neterror.js

index 592964345ac29a3f04254ae6e09ee3dafe671fd8..cee640f7a0a65a4610e34811bca6318e95535cb3 100644

--- a/chrome/renderer/resources/neterror.js

+++ b/chrome/renderer/resources/neterror.js

@@ -12,8 +12,13 @@ function toggleHelpBox() {

detailsButton.innerText = detailsButton.hideDetailsText;

// Details appears over the main content on small screens.

- if (mobileNav)

+ if (mobileNav) {

document.getElementById('main-content').classList.toggle('hidden');

+ var runnerContainer = document.querySelector('.runner-container');

+ if (runnerContainer) {

+ runnerContainer.classList.toggle('hidden');

+ }

}

function diagnoseErrors() {

@@ -142,7 +147,6 @@ function onDocumentLoad() {

if (loadTimeData.valueExists('summary') &&

!loadTimeData.getValue('summary').msg) {

detailsButton.style.display = 'none';

- document.getElementById('details').style.display = 'block';

}

</if>

« no previous file with comments | « chrome/renderer/resources/neterror.html ('k') | chrome/renderer/resources/offline.js » ('j') | no next file with comments »