Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 952543002: Correct paths in gypi files in components. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct paths in gypi files in components. Followup to https://codereview.chromium.org/658383003 (constrained_window) https://codereview.chromium.org/808773005 (component_updater and update_client) This fixes warnings in gyp's msvs-ninja generator. R=blundell@chromium.org,oshima@chromium.org,sorin@chromium.org BUG=459058, 410499 Committed: https://crrev.com/e5938a2d887bd71f1cf0df76d5d72e0a6318f888 Cr-Commit-Position: refs/heads/master@{#317589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/component_updater.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/component_updater/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/constrained_window.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/constrained_window/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Daniel Bratell
5 years, 10 months ago (2015-02-23 15:14:05 UTC) #1
blundell
lgtm
5 years, 10 months ago (2015-02-23 15:14:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952543002/1
5 years, 10 months ago (2015-02-23 15:33:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 16:20:00 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 16:20:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5938a2d887bd71f1cf0df76d5d72e0a6318f888
Cr-Commit-Position: refs/heads/master@{#317589}

Powered by Google App Engine
This is Rietveld 408576698