Issue 952543002: Correct paths in gypi files in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 952543002: Correct paths in gypi files in components. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell

Modified:
5 years, 10 months ago

Reviewers:
Sorin Jianu, oshima, blundell

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Correct paths in gypi files in components. Followup to https://codereview.chromium.org/658383003 (constrained_window) https://codereview.chromium.org/808773005 (component_updater and update_client) This fixes warnings in gyp's msvs-ninja generator. R=blundell@chromium.org,oshima@chromium.org,sorin@chromium.org BUG=459058, 410499 Committed: https://crrev.com/e5938a2d887bd71f1cf0df76d5d72e0a6318f888 Cr-Commit-Position: refs/heads/master@{#317589}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	components/component_updater.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/component_updater/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/constrained_window.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/constrained_window/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/update_client.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/update_client/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952543002/1

5 years, 10 months ago (2015-02-23 15:33:35 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 16:20:22 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e5938a2d887bd71f1cf0df76d5d72e0a6318f888
Cr-Commit-Position: refs/heads/master@{#317589}