Chromium Code Reviews

Issue 808773005: Move most of the component updater artifacts to update_client. (Closed)

Created:
5 years, 11 months ago by Sorin Jianu
Modified:
5 years, 11 months ago
Reviewers:
waffles, jam, blundell
CC:
chromium-reviews, cbentzel+watch_chromium.org, pam+watch_chromium.org, cpu_(ooo_6.6-7.5), Ken Rockot(use gerrit already), asargent_no_longer_on_chrome
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is a mechanical change. It is large but straightforward in its intention. jam: please review the changes under //src/chrome/browser blundell: please review the changes under //src/components waffles: please review the component updater and the update client changes. The intention here is to move most of the component updater dependencies to update_client, with the goal of creating an update_client Chrome component that encapsulates the details of talking with the update servers, downloading, and invoking installers of CRXs for both extensions and components. The dependencies should be: component_updater->update_client. This change just lays down some of the code that will be further used by update_client. No functionality is provided in this change. Also consider the overall goal as WIP; therefore, some of the naming and dependencies are not final. We want to have most of the code in place for future work, but want to minimize the changes to the existing production code and keep the refactoring mechanical for this change. BUG=450337 Committed: https://crrev.com/52ac088530b109fa506c4491aea8cf12bcadc63d Cr-Commit-Position: refs/heads/master@{#312986}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed permissions on ELF files #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rebase and fix dependencies of component updater #

Patch Set 5 : upload with --similarity=100 #

Patch Set 6 : #

Patch Set 7 : linux, --similarity=100 #

Patch Set 8 : #

Unified diffs Side-by-side diffs Stats (+6899 lines, -7004 lines)
M chrome/browser/browser_process_impl.cc View 1 chunk +3 lines, -2 lines 0 comments
M chrome/browser/component_updater/chrome_component_updater_configurator.h View 2 chunks +2 lines, -4 lines 0 comments
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 1 chunk +4 lines, -1 line 0 comments
M chrome/browser/component_updater/component_patcher_operation_out_of_process.h View 2 chunks +2 lines, -2 lines 0 comments
M chrome/browser/component_updater/component_patcher_operation_out_of_process.cc View 1 chunk +2 lines, -2 lines 0 comments
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 3 chunks +3 lines, -2 lines 0 comments
M chrome/browser/component_updater/pnacl/pnacl_component_installer.h View 3 chunks +5 lines, -3 lines 0 comments
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -0 lines 0 comments
M chrome/browser/component_updater/recovery_component_installer.cc View 3 chunks +3 lines, -2 lines 0 comments
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 2 chunks +4 lines, -3 lines 0 comments
M chrome/browser/component_updater/swiftshader_component_installer.cc View 3 chunks +3 lines, -2 lines 0 comments
M chrome/browser/component_updater/test/component_updater_service_unittest.h View 2 chunks +16 lines, -10 lines 0 comments
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 3 chunks +21 lines, -6 lines 0 comments
M chrome/browser/component_updater/test/supervised_user_whitelist_installer_unittest.cc View 1 chunk +6 lines, -1 line 0 comments
M chrome/browser/net/crl_set_fetcher.h View 2 chunks +6 lines, -2 lines 0 comments
M chrome/browser/net/crl_set_fetcher.cc View 2 chunks +2 lines, -1 line 0 comments
M chrome/browser/ui/webui/components_ui.h View 2 chunks +4 lines, -2 lines 0 comments
M chrome/browser/ui/webui/components_ui.cc View 4 chunks +14 lines, -15 lines 0 comments
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments
M chrome/test/BUILD.gn View 3 chunks +2 lines, -4 lines 0 comments
M components/BUILD.gn View 2 chunks +1 line, -1 line 0 comments
M components/component_updater.gypi View 1 chunk +0 lines, -47 lines 0 comments
M components/component_updater/BUILD.gn View 1 chunk +0 lines, -73 lines 0 comments
M components/component_updater/DEPS View 1 chunk +1 line, -7 lines 0 comments
D components/component_updater/background_downloader_win.h View 1 chunk +0 lines, -119 lines 0 comments
D components/component_updater/background_downloader_win.cc View 1 chunk +0 lines, -770 lines 0 comments
D components/component_updater/component_patcher.h View 1 chunk +0 lines, -102 lines 0 comments
D components/component_updater/component_patcher.cc View 1 chunk +0 lines, -125 lines 0 comments
D components/component_updater/component_patcher_operation.h View 1 chunk +0 lines, -184 lines 0 comments
D components/component_updater/component_patcher_operation.cc View 1 chunk +0 lines, -266 lines 0 comments
D components/component_updater/component_unpacker.h View 1 chunk +0 lines, -162 lines 0 comments
D components/component_updater/component_unpacker.cc View 1 chunk +0 lines, -288 lines 0 comments
D components/component_updater/component_updater_configurator.h View 1 chunk +0 lines, -116 lines 0 comments
D components/component_updater/component_updater_ping_manager.h View 1 chunk +0 lines, -32 lines 0 comments
D components/component_updater/component_updater_ping_manager.cc View 1 chunk +0 lines, -213 lines 0 comments
M components/component_updater/component_updater_service.h View 4 chunks +16 lines, -57 lines 0 comments
M components/component_updater/component_updater_service.cc View 3 chunks +21 lines, -32 lines 0 comments
D components/component_updater/component_updater_utils.h View 1 chunk +0 lines, -90 lines 0 comments
D components/component_updater/component_updater_utils.cc View 1 chunk +0 lines, -198 lines 0 comments
D components/component_updater/crx_downloader.h View 1 chunk +0 lines, -156 lines 0 comments
D components/component_updater/crx_downloader.cc View 1 chunk +0 lines, -158 lines 0 comments
D components/component_updater/crx_update_item.h View 1 chunk +0 lines, -129 lines 0 comments
M components/component_updater/default_component_installer.h View 3 chunks +4 lines, -2 lines 0 comments
M components/component_updater/default_component_installer.cc View 2 chunks +7 lines, -3 lines 0 comments
D components/component_updater/request_sender.h View 1 chunk +0 lines, -64 lines 0 comments
D components/component_updater/request_sender.cc View 1 chunk +0 lines, -70 lines 0 comments
D components/component_updater/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments
D components/component_updater/test/component_patcher_unittest.h View 1 chunk +0 lines, -42 lines 0 comments
D components/component_updater/test/component_patcher_unittest.cc View 1 chunk +0 lines, -207 lines 0 comments
D components/component_updater/test/component_updater_ping_manager_unittest.cc View 1 chunk +0 lines, -177 lines 0 comments
D components/component_updater/test/crx_downloader_unittest.cc View 1 chunk +0 lines, -378 lines 0 comments
D components/component_updater/test/request_sender_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments
D components/component_updater/test/test_configurator.h View 1 chunk +0 lines, -88 lines 0 comments
D components/component_updater/test/test_configurator.cc View 1 chunk +0 lines, -154 lines 0 comments
D components/component_updater/test/test_installer.h View 1 chunk +0 lines, -79 lines 0 comments
D components/component_updater/test/test_installer.cc View 1 chunk +0 lines, -86 lines 0 comments
D components/component_updater/test/update_checker_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments
D components/component_updater/test/update_response_unittest.cc View 1 chunk +0 lines, -301 lines 0 comments
D components/component_updater/test/url_request_post_interceptor.h View 1 chunk +0 lines, -184 lines 0 comments
D components/component_updater/test/url_request_post_interceptor.cc View 1 chunk +0 lines, -306 lines 0 comments
D components/component_updater/update_checker.h View 1 chunk +0 lines, -57 lines 0 comments
D components/component_updater/update_checker.cc View 1 chunk +0 lines, -167 lines 0 comments
D components/component_updater/update_response.h View 1 chunk +0 lines, -135 lines 0 comments
D components/component_updater/update_response.cc View 1 chunk +0 lines, -339 lines 0 comments
D components/component_updater/url_fetcher_downloader.h View 1 chunk +0 lines, -60 lines 0 comments
D components/component_updater/url_fetcher_downloader.cc View 1 chunk +0 lines, -109 lines 0 comments
M components/components_tests.gyp View 5 chunks +10 lines, -12 lines 0 comments
D components/test/data/component_updater/OWNERS View 1 chunk +0 lines, -5 lines 0 comments
D components/test/data/component_updater/binary_bsdiff_patch.bin View Binary file 0 comments
D components/test/data/component_updater/binary_courgette_patch.bin View Binary file 0 comments
D components/test/data/component_updater/binary_input.bin View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments
D components/test/data/component_updater/binary_output.bin View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc.pem View 1 chunk +0 lines, -27 lines 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_binary_file View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_text_file View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_static_text_file View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/manifest.json View 1 chunk +0 lines, -5 lines 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f0 View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f1 View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f2 View 1 chunk +0 lines, -5 lines 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f1 View 1 chunk +0 lines, -5 lines 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f2 View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f3 View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_binary_file View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_text_file View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_static_text_file View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/manifest.json View 1 chunk +0 lines, -5 lines 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad.crx View Binary file 0 comments
D components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx View Binary file 0 comments
D components/test/data/component_updater/jebgalgnebhfojomionfpkfelancnnkf.crx View Binary file 0 comments
D components/test/data/component_updater/jebgalgnebhfojomionfpkfelancnnkf.pem View 1 chunk +0 lines, -15 lines 0 comments
D components/test/data/component_updater/jebgalgnebhfojomionfpkfelancnnkf/component1.dll View Binary file 0 comments
D components/test/data/component_updater/jebgalgnebhfojomionfpkfelancnnkf/manifest.json View 1 chunk +0 lines, -9 lines 0 comments
D components/test/data/component_updater/updatecheck_diff_reply_1.xml View 1 chunk +0 lines, -15 lines 0 comments
D components/test/data/component_updater/updatecheck_diff_reply_2.xml View 1 chunk +0 lines, -16 lines 0 comments
D components/test/data/component_updater/updatecheck_diff_reply_3.xml View 1 chunk +0 lines, -6 lines 0 comments
D components/test/data/component_updater/updatecheck_reply_1.xml View 1 chunk +0 lines, -15 lines 0 comments
D components/test/data/component_updater/updatecheck_reply_2.xml View 1 chunk +0 lines, -15 lines 0 comments
D components/test/data/component_updater/updatecheck_reply_3.xml View 1 chunk +0 lines, -6 lines 0 comments
D components/test/data/component_updater/updatecheck_reply_empty View 1 chunk +0 lines, -1 line 0 comments
D components/test/data/component_updater/updatecheck_reply_noupdate.xml View 1 chunk +0 lines, -6 lines 0 comments
A + components/test/data/update_client/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/binary_bsdiff_patch.bin View Binary file 0 comments
A + components/test/data/update_client/binary_courgette_patch.bin View Binary file 0 comments
A + components/test/data/update_client/binary_input.bin View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/binary_output.bin View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc.pem View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_text_file View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_static_text_file View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f0 View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f1 View Binary file 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f2 View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f1 View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f2 View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f3 View Binary file 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_text_file View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_static_text_file View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx View Binary file 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx View Binary file 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad.crx View Binary file 0 comments
A + components/test/data/update_client/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx View Binary file 0 comments
A + components/test/data/update_client/jebgalgnebhfojomionfpkfelancnnkf.crx View Binary file 0 comments
A + components/test/data/update_client/jebgalgnebhfojomionfpkfelancnnkf.pem View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/jebgalgnebhfojomionfpkfelancnnkf/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_diff_reply_1.xml View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_diff_reply_2.xml View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_diff_reply_3.xml View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_reply_1.xml View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_reply_2.xml View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_reply_3.xml View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_reply_empty View 0 chunks +-1 lines, --1 lines 0 comments
A + components/test/data/update_client/updatecheck_reply_noupdate.xml View 0 chunks +-1 lines, --1 lines 0 comments
M components/update_client.gypi View 1 chunk +59 lines, -3 lines 0 comments
M components/update_client/BUILD.gn View 1 chunk +76 lines, -0 lines 0 comments
M components/update_client/DEPS View 1 chunk +8 lines, -0 lines 0 comments
A components/update_client/background_downloader_win.h View 1 2 3 4 6 1 chunk +119 lines, -0 lines 0 comments
A components/update_client/background_downloader_win.cc View 1 2 3 4 6 1 chunk +762 lines, -0 lines 0 comments
A components/update_client/component_patcher.h View 1 2 3 4 6 1 chunk +102 lines, -0 lines 0 comments
A components/update_client/component_patcher.cc View 1 2 3 4 6 1 chunk +121 lines, -0 lines 0 comments
A components/update_client/component_patcher_operation.h View 1 2 3 4 6 1 chunk +184 lines, -0 lines 0 comments
A components/update_client/component_patcher_operation.cc View 1 2 3 4 6 1 chunk +262 lines, -0 lines 0 comments
A components/update_client/component_unpacker.h View 1 2 3 4 6 1 chunk +162 lines, -0 lines 0 comments
A components/update_client/component_unpacker.cc View 1 2 3 4 6 1 chunk +279 lines, -0 lines 0 comments
A components/update_client/configurator.h View 1 2 3 4 6 1 chunk +119 lines, -0 lines 0 comments
A components/update_client/crx_downloader.h View 1 2 3 4 6 1 chunk +156 lines, -0 lines 0 comments
A components/update_client/crx_downloader.cc View 1 2 3 4 6 1 chunk +157 lines, -0 lines 0 comments
A components/update_client/crx_update_item.h View 1 2 3 4 6 1 chunk +129 lines, -0 lines 0 comments
A components/update_client/ping_manager.h View 1 2 3 4 6 1 chunk +32 lines, -0 lines 0 comments
A components/update_client/ping_manager.cc View 1 2 3 4 6 1 chunk +202 lines, -0 lines 0 comments
A components/update_client/request_sender.h View 1 2 3 4 6 1 chunk +64 lines, -0 lines 0 comments
A components/update_client/request_sender.cc View 1 2 3 4 6 1 chunk +70 lines, -0 lines 0 comments
A + components/update_client/test/DEPS View 0 chunks +-1 lines, --1 lines 0 comments
A components/update_client/test/component_patcher_unittest.h View 1 2 3 4 6 1 chunk +42 lines, -0 lines 0 comments
A components/update_client/test/component_patcher_unittest.cc View 1 2 3 4 6 1 chunk +200 lines, -0 lines 0 comments
A components/update_client/test/crx_downloader_unittest.cc View 1 2 3 4 6 1 chunk +382 lines, -0 lines 0 comments
A components/update_client/test/ping_manager_unittest.cc View 1 2 3 4 6 1 chunk +177 lines, -0 lines 0 comments
A components/update_client/test/request_sender_unittest.cc View 1 2 3 4 6 1 chunk +205 lines, -0 lines 0 comments
A components/update_client/test/test_configurator.h View 1 2 3 4 6 1 chunk +107 lines, -0 lines 0 comments
A components/update_client/test/test_configurator.cc View 1 2 3 4 6 1 chunk +154 lines, -0 lines 0 comments
A components/update_client/test/test_installer.h View 1 2 3 4 6 1 chunk +79 lines, -0 lines 0 comments
A components/update_client/test/test_installer.cc View 1 2 3 4 6 1 chunk +86 lines, -0 lines 0 comments
A components/update_client/test/update_checker_unittest.cc View 1 2 3 4 6 1 chunk +237 lines, -0 lines 0 comments
A components/update_client/test/update_response_unittest.cc View 1 2 3 4 6 1 chunk +302 lines, -0 lines 0 comments
A components/update_client/test/url_request_post_interceptor.h View 1 2 3 4 6 1 chunk +165 lines, -0 lines 0 comments
A components/update_client/test/url_request_post_interceptor.cc View 1 2 3 4 6 1 chunk +301 lines, -0 lines 0 comments
A components/update_client/update_checker.h View 1 2 3 4 6 1 chunk +57 lines, -0 lines 0 comments
A components/update_client/update_checker.cc View 1 2 3 4 6 1 chunk +163 lines, -0 lines 0 comments
A components/update_client/update_client.h View 1 chunk +71 lines, -0 lines 0 comments
A components/update_client/update_client.cc View 1 chunk +33 lines, -0 lines 0 comments
A components/update_client/update_response.h View 1 2 3 4 6 1 chunk +135 lines, -0 lines 0 comments
A components/update_client/update_response.cc View 1 2 3 4 6 1 chunk +349 lines, -0 lines 0 comments
A components/update_client/url_fetcher_downloader.h View 1 2 3 4 6 1 chunk +60 lines, -0 lines 0 comments
A components/update_client/url_fetcher_downloader.cc View 1 2 3 4 6 1 chunk +109 lines, -0 lines 0 comments
A components/update_client/utils.h View 1 2 3 4 6 1 chunk +90 lines, -0 lines 0 comments
A components/update_client/utils.cc View 1 2 3 4 6 1 chunk +195 lines, -0 lines 0 comments

Messages

Total messages: 18 (6 generated)
Sorin Jianu
jam, blundell: I need owners review please. Thank you, sorry for the large refactoring and ...
5 years, 11 months ago (2015-01-20 21:08:24 UTC) #2
waffles
lgtm Overall there are many formatting changes by `git cl format` that I dislike, but ...
5 years, 11 months ago (2015-01-20 21:49:07 UTC) #3
jam
chrome/browser (other than component_updater subdir) lgtm
5 years, 11 months ago (2015-01-21 04:49:26 UTC) #4
blundell
//components LGTM outside of changes inside the individual components and their individual test data https://codereview.chromium.org/808773005/diff/40001/components/components_tests.gyp ...
5 years, 11 months ago (2015-01-21 10:29:04 UTC) #5
Sorin Jianu
Thank you Colin! https://codereview.chromium.org/808773005/diff/40001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/808773005/diff/40001/components/components_tests.gyp#newcode353 components/components_tests.gyp:353: # Dependencies of component_updater On 2015/01/21 ...
5 years, 11 months ago (2015-01-21 18:29:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808773005/60001
5 years, 11 months ago (2015-01-21 18:33:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37321) Try jobs failed on following ...
5 years, 11 months ago (2015-01-21 18:45:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808773005/80001
5 years, 11 months ago (2015-01-21 21:53:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37396)
5 years, 11 months ago (2015-01-21 22:04:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808773005/140001
5 years, 11 months ago (2015-01-23 23:59:30 UTC) #16
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 11 months ago (2015-01-24 01:15:44 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 01:16:58 UTC) #18
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/52ac088530b109fa506c4491aea8cf12bcadc63d
Cr-Commit-Position: refs/heads/master@{#312986}

Powered by Google App Engine