Remove NativeContext from Literal array, since we always create the literals in the native context …

Remove NativeContext from Literal array, since we always create the literals in the native context of the current closure.

BUG=

Committed: https://crrev.com/6b1bddb454bd1887e3c3e7aae785447f015c492b
Cr-Commit-Position: refs/heads/master@{#26867}

[Toon Verwaest, 2015-02-25 18:14:13]

verwaest@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Toon Verwaest, 2015-02-25 18:14:13]

PTAL

[Michael Starzinger, 2015-02-25 21:32:33]

LGTM with a coupla nits.

https://codereview.chromium.org/952303002/diff/20001/src/liveedit.cc
File src/liveedit.cc (right):

https://codereview.chromium.org/952303002/diff/20001/src/liveedit.cc#newcode1013
src/liveedit.cc:1013: Handle<FixedArray> old_literals(fun->literals());
nit: The old_literals handle seems to be unused.

https://codereview.chromium.org/952303002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/952303002/diff/20001/src/objects.h#newcode7577
src/objects.h:7577: static Context* NativeContextFromLiterals(FixedArray*
literals);
nit: Implementation is gone, let's also remove the declaration.

https://codereview.chromium.org/952303002/diff/20001/src/runtime/runtime-rege...
File src/runtime/runtime-regexp.cc (right):

https://codereview.chromium.org/952303002/diff/20001/src/runtime/runtime-rege...
src/runtime/runtime-regexp.cc:932: // from another context which we should not
have access to.
nit: The entire comment is obsolete. Let's drop it.

https://codereview.chromium.org/952303002/diff/20001/test/cctest/test-heap-pr...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/952303002/diff/20001/test/cctest/test-heap-pr...
test/cctest/test-heap-profiler.cc:2297: // The second value in the literals
array should be the boilerplate,
nit: This comment is confusing, should we s/second/first/ here?

[Toon Verwaest, 2015-02-25 21:57:47]

Addressed comments

https://codereview.chromium.org/952303002/diff/20001/src/liveedit.cc
File src/liveedit.cc (right):

https://codereview.chromium.org/952303002/diff/20001/src/liveedit.cc#newcode1013
src/liveedit.cc:1013: Handle<FixedArray> old_literals(fun->literals());
On 2015/02/25 21:32:33, Michael Starzinger wrote:
> nit: The old_literals handle seems to be unused.

Done.

https://codereview.chromium.org/952303002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/952303002/diff/20001/src/objects.h#newcode7577
src/objects.h:7577: static Context* NativeContextFromLiterals(FixedArray*
literals);
On 2015/02/25 21:32:33, Michael Starzinger wrote:
> nit: Implementation is gone, let's also remove the declaration.

Done.

https://codereview.chromium.org/952303002/diff/20001/src/runtime/runtime-rege...
File src/runtime/runtime-regexp.cc (right):

https://codereview.chromium.org/952303002/diff/20001/src/runtime/runtime-rege...
src/runtime/runtime-regexp.cc:932: // from another context which we should not
have access to.
On 2015/02/25 21:32:33, Michael Starzinger wrote:
> nit: The entire comment is obsolete. Let's drop it.

Done.

https://codereview.chromium.org/952303002/diff/20001/test/cctest/test-heap-pr...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/952303002/diff/20001/test/cctest/test-heap-pr...
test/cctest/test-heap-profiler.cc:2297: // The second value in the literals
array should be the boilerplate,
On 2015/02/25 21:32:33, Michael Starzinger wrote:
> nit: This comment is confusing, should we s/second/first/ here?

Done.

[Toon Verwaest, 2015-02-25 21:57:57]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-02-25 21:57:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/952303002/#ps40001 (title:
"Addressed comments")

[commit-bot: I haz the power, 2015-02-25 21:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952303002/40001

[commit-bot: I haz the power, 2015-02-25 22:41:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-25 22:42:03]

Patchset 3 (id:??) landed as
https://crrev.com/6b1bddb454bd1887e3c3e7aae785447f015c492b
Cr-Commit-Position: refs/heads/master@{#26867}