src/runtime/runtime-function.cc - Issue 952303002: Remove NativeContext from Literal array, since we always create the literals in the native context …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-function.cc

Issue 952303002: Remove NativeContext from Literal array, since we always create the literals in the native context … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-function.cc

diff --git a/src/runtime/runtime-function.cc b/src/runtime/runtime-function.cc

index 75aeed74bed77f96de8da9cb4014bdabd73e84d5..e8b160d1c529353134ad2a045faec0d5d1f040a5 100644

--- a/src/runtime/runtime-function.cc

+++ b/src/runtime/runtime-function.cc

@@ -295,10 +295,6 @@ RUNTIME_FUNCTION(Runtime_SetCode) {

int number_of_literals = source->NumberOfLiterals();

Handle<FixedArray> literals =

isolate->factory()->NewFixedArray(number_of_literals, TENURED);

- if (number_of_literals > 0) {

- literals->set(JSFunction::kLiteralNativeContextIndex,

- context->native_context());

- }

target->set_context(*context);

target->set_literals(*literals);

« no previous file with comments | « src/preparser.h ('k') | src/runtime/runtime-literals.cc » ('j') | no next file with comments »