Issue 952263002: aw: Fix selection handle hit testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 952263002: aw: Fix selection handle hit testing (Closed)

Created:
5 years, 10 months ago by jdduke (slow)

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

aw: Fix selection handle hit testing Return the y coordinate of the PopupTouchHandleDrawable position when it is requested. Turns out, returning the x coordinate is bad. BUG=461598 Review URL: https://codereview.chromium.org/931283008 Cr-Commit-Position: refs/heads/master@{#317936} (cherry picked from commit 048b41f6da21aa71b2f00dd41d695d362f046af1) Committed: https://chromium.googlesource.com/chromium/src/+/8be8b38a2c30279a89e497ff449cf303461df461

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

jdduke (slow)

5 years, 10 months ago (2015-02-25 16:35:25 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8be8b38a2c30279a89e497ff449cf303461df461.