Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 931283008: aw: Fix selection handle hit testing (Closed)

Created:
5 years, 10 months ago by jdduke (slow)
Modified:
5 years, 10 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix selection handle hit testing Return the y coordinate of the PopupTouchHandleDrawable position when it is requested. Turns out, returning the x coordinate is bad. BUG=461598 Committed: https://crrev.com/048b41f6da21aa71b2f00dd41d695d362f046af1 Cr-Commit-Position: refs/heads/master@{#317936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jdduke (slow)
hush@: PTAL, thanks.
5 years, 10 months ago (2015-02-25 00:00:05 UTC) #2
hush (inactive)
lgtm
5 years, 10 months ago (2015-02-25 00:07:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931283008/1
5 years, 10 months ago (2015-02-25 00:08:52 UTC) #5
jdduke (slow)
On 2015/02/25 00:00:05, jdduke wrote: > hush@: PTAL, thanks. At some point we really ought ...
5 years, 10 months ago (2015-02-25 00:10:08 UTC) #6
hush (inactive)
On 2015/02/25 00:10:08, jdduke wrote: > On 2015/02/25 00:00:05, jdduke wrote: > > hush@: PTAL, ...
5 years, 10 months ago (2015-02-25 00:13:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 01:13:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 01:13:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/048b41f6da21aa71b2f00dd41d695d362f046af1
Cr-Commit-Position: refs/heads/master@{#317936}

Powered by Google App Engine
This is Rietveld 408576698