Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 95223003: Remove plumbing for showing HTML notifications from content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index b19cd19ec43d791f1fc238f5095f7ada8d5a0f1e..92d4fa5e4f0068d83f1f9f4accf42a9bce69fefc 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -2203,15 +2203,6 @@ void RenderViewHostImpl::OnRequestDesktopNotificationPermission(
void RenderViewHostImpl::OnShowDesktopNotification(
const ShowDesktopNotificationHostMsgParams& params) {
- // Disallow HTML notifications from javascript: and file: schemes as this
- // allows unwanted cross-domain access.
- GURL url = params.contents_url;
- if (params.is_html &&
- (url.SchemeIs(kJavaScriptScheme) ||
- url.SchemeIs(chrome::kFileScheme))) {
- return;
- }
-
GetContentClient()->browser()->ShowDesktopNotification(
params, GetProcess()->GetID(), GetRoutingID(), false);
}
« no previous file with comments | « chrome/browser/notifications/desktop_notifications_unittest.cc ('k') | content/common/desktop_notification_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698