Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2415)

Unified Diff: chrome/browser/notifications/desktop_notifications_unittest.cc

Issue 95223003: Remove plumbing for showing HTML notifications from content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/desktop_notifications_unittest.cc
diff --git a/chrome/browser/notifications/desktop_notifications_unittest.cc b/chrome/browser/notifications/desktop_notifications_unittest.cc
index 0cd63b1c9e63aa6a5b90d0f2fe94f5be3c44ee5a..9105786e69366e799066f5a2bbc52d9ee2dc4e1b 100644
--- a/chrome/browser/notifications/desktop_notifications_unittest.cc
+++ b/chrome/browser/notifications/desktop_notifications_unittest.cc
@@ -145,7 +145,6 @@ DesktopNotificationsTest::StandardTestNotification() {
content::ShowDesktopNotificationHostMsgParams params;
params.notification_id = 0;
params.origin = GURL("http://www.google.com");
- params.is_html = false;
params.icon_url = GURL("/icon.png");
params.title = ASCIIToUTF16("Title");
params.body = ASCIIToUTF16("Text");
@@ -163,11 +162,11 @@ TEST_F(DesktopNotificationsTest, TestShow) {
base::MessageLoopForUI::current()->RunUntilIdle();
EXPECT_EQ(1, balloon_collection_->count());
- content::ShowDesktopNotificationHostMsgParams params2;
- params2.origin = GURL("http://www.google.com");
- params2.is_html = true;
- params2.contents_url = GURL("http://www.google.com/notification.html");
+ content::ShowDesktopNotificationHostMsgParams params2 =
+ StandardTestNotification();
params2.notification_id = 2;
+ params2.origin = GURL("http://www.google.com");
+ params2.body = ASCIIToUTF16("Text");
EXPECT_TRUE(service_->ShowDesktopNotification(
params2, 0, 0, DesktopNotificationService::PageNotification));
@@ -254,7 +253,6 @@ TEST_F(DesktopNotificationsTest, TestPositioning) {
TEST_F(DesktopNotificationsTest, TestVariableSize) {
content::ShowDesktopNotificationHostMsgParams params;
params.origin = GURL("http://long.google.com");
- params.is_html = false;
params.icon_url = GURL("/icon.png");
params.title = ASCIIToUTF16("Really Really Really Really Really Really "
"Really Really Really Really Really Really "
« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698