Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 95223003: Remove plumbing for showing HTML notifications from content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notifications_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/desktop_notification_service.cc
diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc
index ca3caaeca24d050a0701d5fed1a61a03086c2b42..afbf55d9863b12bf3993e8fab790a5abdaf7328c 100644
--- a/chrome/browser/notifications/desktop_notification_service.cc
+++ b/chrome/browser/notifications/desktop_notification_service.cc
@@ -494,17 +494,14 @@ bool DesktopNotificationService::ShowDesktopNotification(
source == WorkerNotification);
string16 display_source = DisplayNameForOriginInProcessId(origin, process_id);
- if (params.is_html) {
- ShowNotification(Notification(origin, params.contents_url, display_source,
- params.replace_id, proxy));
- } else {
- Notification notification(origin, params.icon_url, params.title,
- params.body, params.direction, display_source, params.replace_id,
- proxy);
- // The webkit notification doesn't timeout.
- notification.set_never_timeout(true);
- ShowNotification(notification);
- }
+ Notification notification(origin, params.icon_url, params.title,
+ params.body, params.direction, display_source, params.replace_id,
+ proxy);
+
+ // The webkit notification doesn't timeout.
+ notification.set_never_timeout(true);
+
+ ShowNotification(notification);
return true;
}
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notifications_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698