Issue 95223003: Remove plumbing for showing HTML notifications from content/.

Issue 95223003: Remove plumbing for showing HTML notifications from content/. (Closed)

Created:
7 years ago by Peter Beverloo

Modified:
7 years ago

Reviewers:
kenrb, jochen (gone - plz use gerrit), Andrew T Wilson (Slow)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove plumbing for showing HTML notifications from content/. WebNotification::isHTML() has been returning false since late July when we removed the Web Exposed entry point, so all of this is dead code. The removal shipped in Chrome 30, so it's unlikely to return. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238415

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -72 lines)			Patch
M	chrome/browser/notifications/desktop_notification_service.cc	View		1 chunk	+8 lines, -11 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.cc	View	1	3 chunks	+4 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/common/desktop_notification_messages.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/common/show_desktop_notification_params.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/public/common/show_desktop_notification_params.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/notification_provider.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/renderer/notification_provider.cc	View		2 chunks	+11 lines, -33 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/95223003/20001

7 years ago (2013-11-29 12:00:41 UTC) #4

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=38677

7 years ago (2013-11-29 12:14:36 UTC) #5

Peter Beverloo

+kenrb for IPC message field removal (as only non-US security OWNER).

7 years ago (2013-11-29 12:26:35 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/95223003/20001

7 years ago (2013-12-03 14:04:09 UTC) #8

Message was sent while issue was closed.

Change committed as 238415

Expand Messages | Collapse Messages