Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 952133003: Revert of Enabled gpu_times metrics. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
David Yen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enabled gpu_times metrics. (patchset #1 id:1 of https://codereview.chromium.org/937073003/) Reason for revert: Causing not redness. Original issue's description: > Enabled gpu_times metrics. > > The issue where gpu_times would use too much memory has been fixed: > https://codereview.chromium.org/920523002 > > In order to prepare for future changes where additional metrics > will be added to the TBM module, I have also preemptively added a > filter function which filters out values relating to gpu_times. > > R=nednguyen@chromium.org > BUG=455292, 453131 > TEST=local runs measuring memory usage shows ~700mb > > Committed: https://crrev.com/ed5b27a7459e35248992fd5549b72b5731a8baa4 > Cr-Commit-Position: refs/heads/master@{#317974} TBR=dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455292, 453131 Committed: https://crrev.com/e917b49708a65bcf4295ee872ea2fb8e94b3bbcf Cr-Commit-Position: refs/heads/master@{#318034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -31 lines) Patch
M tools/perf/benchmarks/gpu_times.py View 4 chunks +4 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py View 2 chunks +12 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nednguyen
Created Revert of Enabled gpu_times metrics.
5 years, 10 months ago (2015-02-25 13:22:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952133003/1
5 years, 10 months ago (2015-02-25 13:23:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 13:23:49 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 13:24:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e917b49708a65bcf4295ee872ea2fb8e94b3bbcf
Cr-Commit-Position: refs/heads/master@{#318034}

Powered by Google App Engine
This is Rietveld 408576698