Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: tools/perf/benchmarks/gpu_times.py

Issue 952133003: Revert of Enabled gpu_times metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/gpu_times.py
diff --git a/tools/perf/benchmarks/gpu_times.py b/tools/perf/benchmarks/gpu_times.py
index 374a0cc0dee9f762a2284d036c11eefcdfd74dc2..13915bbd969858627eb36919bfbc59409b19242f 100644
--- a/tools/perf/benchmarks/gpu_times.py
+++ b/tools/perf/benchmarks/gpu_times.py
@@ -26,12 +26,8 @@
overhead_level=cat_filter,
get_metrics_from_flags_callback=_GetGPUTimelineMetric)
- @classmethod
- def ValueCanBeAddedPredicate(cls, value):
- return (isinstance(value, gpu_timeline.GPUTimelineListOfValues) or
- isinstance(value, gpu_timeline.GPUTimelineValue))
-
+@benchmark.Disabled # http://crbug.com/455292
class GPUTimesKeyMobileSites(_GPUTimes):
"""Measures GPU timeline metric on key mobile sites."""
page_set = page_sets.KeyMobileSitesSmoothPageSet
@@ -40,7 +36,7 @@
def Name(cls):
return 'gpu_times.key_mobile_sites_smooth'
-
+@benchmark.Disabled # http://crbug.com/455292
class GPUTimesGpuRasterizationKeyMobileSites(_GPUTimes):
"""Measures GPU timeline metric on key mobile sites with GPU rasterization.
"""
@@ -52,7 +48,7 @@
def Name(cls):
return 'gpu_times.gpu_rasterization.key_mobile_sites_smooth'
-
+@benchmark.Disabled # http://crbug.com/453131, http://crbug.com/455292
class GPUTimesTop25Sites(_GPUTimes):
"""Measures GPU timeline metric for the top 25 sites."""
page_set = page_sets.Top25SmoothPageSet
@@ -61,7 +57,7 @@
def Name(cls):
return 'gpu_times.top_25_smooth'
-
+@benchmark.Disabled # http://crbug.com/455292
class GPUTimesGpuRasterizationTop25Sites(_GPUTimes):
"""Measures GPU timeline metric for the top 25 sites with GPU rasterization.
"""
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698