Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 951783003: Proper focus input field instead of whole pod (Closed)

Created:
5 years, 10 months ago by Dmitry Polukhin
Modified:
5 years, 10 months ago
Reviewers:
xiyuan, Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Proper focus input field instead of whole pod This CL fixes focus regression introduced in https://codereview.chromium.org/908033005 BUG=450465 TEST=manual Committed: https://crrev.com/2672bd90ba63cb8b19e1b44b9512e52f036bd813 Cr-Commit-Position: refs/heads/master@{#317777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/login/account_picker/user_pod_row.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Polukhin
PTAL
5 years, 10 months ago (2015-02-24 09:33:59 UTC) #2
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-24 09:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951783003/1
5 years, 10 months ago (2015-02-24 09:53:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 10:39:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 10:40:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2672bd90ba63cb8b19e1b44b9512e52f036bd813
Cr-Commit-Position: refs/heads/master@{#317777}

Powered by Google App Engine
This is Rietveld 408576698