Move password reset on login screen from after wake up to before suspend

Move password reset on login screen from after wake up to before suspend

This patch moves password reset on login screen to before suspend time.
Also forced focusing user pod will not reset password as it was before.

BUG=450465
TEST=manual

Committed: https://crrev.com/011b6d7dc582002027dad48b1a8dcf3c9f9de4d6
Cr-Commit-Position: refs/heads/master@{#315553}

[Dmitry Polukhin, 2015-02-10 12:29:22]

dpolukhin@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Dmitry Polukhin, 2015-02-10 12:29:23]

PTAL

[Nikita (slow), 2015-02-10 13:00:10]

lgtm

https://codereview.chromium.org/908033005/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/lock/webui_screen_locker.cc (right):

https://codereview.chromium.org/908033005/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/lock/webui_screen_locker.cc:161:
webui_login_->RequestFocus();
FocusUserPod()

[Dmitry Polukhin, 2015-02-10 13:05:33]

https://codereview.chromium.org/908033005/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/lock/webui_screen_locker.cc (right):

https://codereview.chromium.org/908033005/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/lock/webui_screen_locker.cc:161:
webui_login_->RequestFocus();
On 2015/02/10 13:00:10, Nikita wrote:
> FocusUserPod()

Done.

[Dmitry Polukhin, 2015-02-10 13:06:13]

The CQ bit was checked by dpolukhin@chromium.org

[commit-bot: I haz the power, 2015-02-10 13:06:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908033005/20001

[commit-bot: I haz the power, 2015-02-10 14:00:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-10 14:01:19]

Patchset 2 (id:??) landed as
https://crrev.com/011b6d7dc582002027dad48b1a8dcf3c9f9de4d6
Cr-Commit-Position: refs/heads/master@{#315553}

[Chirantan Ekbote, 2015-02-11 22:53:12]

chirantan@chromium.org changed reviewers:
+ chirantan@chromium.org

[Chirantan Ekbote, 2015-02-11 22:53:12]

https://codereview.chromium.org/908033005/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/lock/webui_screen_locker.cc (right):

https://codereview.chromium.org/908033005/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/lock/webui_screen_locker.cc:327:
content::BrowserThread::PostTask(
This can race with the system suspend if the message loop is particularly busy. 
So the callback might run after a resume instead.  If you want to be sure that
the callback runs before the system suspends, you need to call
GetSuspendReadinessCallback() from the PowerManagerClient and then run that
callback from ResetAndFocusUserPod().

[Dmitry Polukhin, 2015-02-12 11:14:59]

On 2015/02/11 22:53:12, Chirantan Ekbote wrote:
>
https://codereview.chromium.org/908033005/diff/20001/chrome/browser/chromeos/...
> File chrome/browser/chromeos/login/lock/webui_screen_locker.cc (right):
> 
>
https://codereview.chromium.org/908033005/diff/20001/chrome/browser/chromeos/...
> chrome/browser/chromeos/login/lock/webui_screen_locker.cc:327:
> content::BrowserThread::PostTask(
> This can race with the system suspend if the message loop is particularly
busy. 
> So the callback might run after a resume instead.  If you want to be sure that
> the callback runs before the system suspends, you need to call
> GetSuspendReadinessCallback() from the PowerManagerClient and then run that
> callback from ResetAndFocusUserPod().

I think it is not required because later on UI thread we will send message to JS
and there is no guarantee that it will be processed before suspend and we don't
need such strong guarantee IMHO.