Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 951773003: Register sync session ID in SyncController. (Closed)

Created:
5 years, 10 months ago by maxbogue
Modified:
5 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sessions-id
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register sync session ID in SyncController. Removing GSM.setupSessionSyncId() part 3/4. Generate the sync sessions ID in SyncController and cleanup ChromeShellActivity. BUG=428882 Committed: https://crrev.com/852c31238ebdec699b953a6b3d99290a6c9a737a Cr-Commit-Position: refs/heads/master@{#319097}

Patch Set 1 #

Patch Set 2 : Register ID in SyncController and cleanup ChromeShellActivity. #

Patch Set 3 : Rebase on master. #

Total comments: 2

Patch Set 4 : Better comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 5 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
maxbogue
Part 3/4.
5 years, 10 months ago (2015-02-26 23:08:36 UTC) #2
nyquist
other than fixing the comment, lgtm https://codereview.chromium.org/951773003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java File chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java (right): https://codereview.chromium.org/951773003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java#newcode64 chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java:64: // Since we ...
5 years, 9 months ago (2015-03-04 09:15:13 UTC) #3
maxbogue
https://codereview.chromium.org/951773003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java File chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java (right): https://codereview.chromium.org/951773003/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java#newcode64 chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java:64: // Since we do not override the UniqueIdentificationGenerator, we ...
5 years, 9 months ago (2015-03-04 18:40:48 UTC) #4
nyquist
lgtm
5 years, 9 months ago (2015-03-04 18:52:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951773003/60001
5 years, 9 months ago (2015-03-04 18:54:36 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-04 19:16:50 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:18:02 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/852c31238ebdec699b953a6b3d99290a6c9a737a
Cr-Commit-Position: refs/heads/master@{#319097}

Powered by Google App Engine
This is Rietveld 408576698