Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 951773003: Register sync session ID in SyncController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sessions-id
Patch Set: Better comment. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
index d1fd4eef3b6e1beb4cd3adc59537f4f30dfb9845..687fe99c44cbfa1765a377af663da7cacbccf153 100644
--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
@@ -36,8 +36,6 @@ import org.chromium.chrome.browser.Tab;
import org.chromium.chrome.browser.appmenu.AppMenuHandler;
import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
import org.chromium.chrome.browser.dom_distiller.DomDistillerTabUtils;
-import org.chromium.chrome.browser.identity.UniqueIdentificationGeneratorFactory;
-import org.chromium.chrome.browser.identity.UuidBasedUniqueIdentificationGenerator;
import org.chromium.chrome.browser.nfc.BeamController;
import org.chromium.chrome.browser.nfc.BeamProvider;
import org.chromium.chrome.browser.notifications.NotificationUIManager;
@@ -45,7 +43,6 @@ import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import org.chromium.chrome.browser.printing.PrintingControllerFactory;
import org.chromium.chrome.browser.printing.TabPrinter;
import org.chromium.chrome.browser.share.ShareHelper;
-import org.chromium.chrome.browser.sync.ProfileSyncService;
import org.chromium.chrome.browser.sync.SyncController;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
@@ -70,8 +67,6 @@ import org.chromium.ui.base.WindowAndroid;
public class ChromeShellActivity extends ActionBarActivity implements AppMenuPropertiesDelegate {
private static final String TAG = "ChromeShellActivity";
- private static final String SESSIONS_UUID_PREF_KEY = "chromium.sync.sessions.id";
-
/**
* Factory used to set up a mock ActivityWindowAndroid for testing.
*/
@@ -195,8 +190,6 @@ public class ChromeShellActivity extends ActionBarActivity implements AppMenuPro
mPrintingController = PrintingControllerFactory.create(this);
- setupSessionSyncId();
-
mSyncController = SyncController.get(this);
// In case this method is called after the first onStart(), we need to inform the
// SyncController that we have started.
@@ -484,19 +477,6 @@ public class ChromeShellActivity extends ActionBarActivity implements AppMenuPro
sAppMenuHandlerFactory = factory;
}
- private void setupSessionSyncId() {
- // Ensure that sync uses the correct UniqueIdentificationGenerator, but do not force the
- // registration, in case a test case has already overridden it.
- UuidBasedUniqueIdentificationGenerator generator =
- new UuidBasedUniqueIdentificationGenerator(this, SESSIONS_UUID_PREF_KEY);
- UniqueIdentificationGeneratorFactory.registerGenerator(
- UuidBasedUniqueIdentificationGenerator.GENERATOR_ID, generator, false);
- // Since we do not override the UniqueIdentificationGenerator, we get it from the factory,
- // instead of using the instance we just created.
- ProfileSyncService.get(this).setSessionsId(UniqueIdentificationGeneratorFactory
- .getInstance(UuidBasedUniqueIdentificationGenerator.GENERATOR_ID));
- }
-
/**
* Open a dialog that gives the user the option to sign in from a list of available accounts.
*
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698