Issue 951573002: Add validation test cases for struct versioning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 951573002: Add validation test cases for struct versioning. (Closed)

Created:
5 years, 10 months ago by yzshen1

Modified:
5 years, 10 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add validation test cases for struct versioning. This CL skips (some of) them temporarily for Dart, Python and JS. BUG=451205 TEST=Validate tests pass. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a5f2ac831cfa7a6d42202066eaac8907504dfbb3

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -23 lines)			Patch
M	mojo/dart/test/validation_test.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	mojo/public/cpp/bindings/tests/validation_unittest.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version0.data	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version0.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version1.data	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version1.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version2.data	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version2.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version3.data	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version3.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version_newer_than_known_1.data	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version_newer_than_known_1.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version_newer_than_known_2.data	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_good_version_newer_than_known_2.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_num_bytes_version_mismatch_1.data	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_num_bytes_version_mismatch_1.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_num_bytes_version_mismatch_2.data	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_num_bytes_version_mismatch_2.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	mojo/public/interfaces/bindings/tests/data/validation/not_implemented_mthd0_struct_num_fields_less_than_min_requirement.data	View		1 chunk	+0 lines, -12 lines	0 comments	Download
D	mojo/public/interfaces/bindings/tests/data/validation/not_implemented_mthd0_struct_num_fields_less_than_min_requirement.expected	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	mojo/public/js/validation_unittests.js	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	mojo/python/tests/validation_unittest.py	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

yzshen1

5 years, 10 months ago (2015-02-24 17:06:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a5f2ac831cfa7a6d42202066eaac8907504dfbb3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages