ui/file_manager/file_manager/main.html - Issue 951443002: Files.app: Make delete button on the toolbar standard button instead of CommandButton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/main.html

Issue 951443002: Files.app: Make delete button on the toolbar standard button instead of CommandButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: topbar -> toolbar ...orz Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/file_manager/foreground/js/toolbar_controller.js ('K') | « ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/main.html

diff --git a/ui/file_manager/file_manager/main.html b/ui/file_manager/file_manager/main.html

index 8cb4d82af9215ece333ee05e5bdc6c7d05779495..0aa4fc9afb21ae439a8f13b9dd95b167fc4a8486 100644

--- a/ui/file_manager/file_manager/main.html

+++ b/ui/file_manager/file_manager/main.html

@@ -347,7 +347,7 @@

visibleif="full-page">

<paper-ripple fit class="recenteringTouch circle"></paper-ripple>

</button>

- <button id="delete-button" class="icon-button" command="#delete" tabindex="10"

+ <button id="delete-button" class="icon-button" tabindex="10"

hirono 2015/02/23 09:48:37 Can we make this paper-button?

fukino 2015/02/23 11:18:50 We could you <paper-icon-button> for buttons on th

hirono 2015/02/23 11:23:51 SGTM, thanks!

i18n-values="aria-label:DELETE_BUTTON_LABEL"

visibleif="full-page">

<paper-ripple fit class="recenteringTouch circle"></paper-ripple>

« ui/file_manager/file_manager/foreground/js/toolbar_controller.js ('K') | « ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js ('k') | no next file » | no next file with comments »