ui/file_manager/file_manager/main.html - Issue 951443002: Files.app: Make delete button on the toolbar standard button instead of CommandButton.

Side by Side Diff: ui/file_manager/file_manager/main.html

Issue 951443002: Files.app: Make delete button on the toolbar standard button instead of CommandButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: topbar -> toolbar ...orz Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <!--	2 <!--

3 -- Copyright (c) 2012 The Chromium Authors. All rights reserved.	3 -- Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 -- Use of this source code is governed by a BSD-style license that can be	4 -- Use of this source code is governed by a BSD-style license that can be

5 -- found in the LICENSE file.	5 -- found in the LICENSE file.

6 -->	6 -->

7 <html i18n-values="dir:textdirection;lang:language">	7 <html i18n-values="dir:textdirection;lang:language">

8 <head>	8 <head>

9 <!-- We have to set some default title, or chrome will use the page name.	9 <!-- We have to set some default title, or chrome will use the page name.

10 -- As soon as we init and change to a directory, we'll show the directory	10 -- As soon as we init and change to a directory, we'll show the directory

(...skipping 329 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
340 <paper-input-decorator i18n-values="label:SEARCH_TEXT_LABEL">	340 <paper-input-decorator i18n-values="label:SEARCH_TEXT_LABEL">

341 <input is="core-input" type="search" tabindex="-1"	341 <input is="core-input" type="search" tabindex="-1"

342 i18n-values="aria-label:SEARCH_TEXT_LABEL">	342 i18n-values="aria-label:SEARCH_TEXT_LABEL">

343 </paper-input-decorator>	343 </paper-input-decorator>

344 </div>	344 </div>

345 <button id="share-button" class="icon-button" command="#share" tabindex="9 "	345 <button id="share-button" class="icon-button" command="#share" tabindex="9 "

346 i18n-values="aria-label:SHARE_BUTTON_LABEL"	346 i18n-values="aria-label:SHARE_BUTTON_LABEL"

347 visibleif="full-page">	347 visibleif="full-page">

348 <paper-ripple fit class="recenteringTouch circle"></paper-ripple>	348 <paper-ripple fit class="recenteringTouch circle"></paper-ripple>

349 </button>	349 </button>

350 <button id="delete-button" class="icon-button" command="#delete" tabindex= "10"	350 <button id="delete-button" class="icon-button" tabindex="10"
	hirono 2015/02/23 09:48:37 Can we make this paper-button? Can we make this paper-button? fukino 2015/02/23 11:18:50 We could you <paper-icon-button> for buttons on th Show quoted text On 2015/02/23 09:48:37, hirono wrote: > Can we make this paper-button? We could you <paper-icon-button> for buttons on the toolbar, but for now other non-command buttons don't use <paper-icon-button>. I wanted to keep using <button> for consistency and for safety to merge this to M42. WDYT? hirono 2015/02/23 11:23:51 SGTM, thanks! Show quoted text On 2015/02/23 11:18:50, fukino wrote: > On 2015/02/23 09:48:37, hirono wrote: > > Can we make this paper-button? > > We could you <paper-icon-button> for buttons on the toolbar, but for now other > non-command buttons don't use <paper-icon-button>. I wanted to keep using > <button> for consistency and for safety to merge this to M42. WDYT? SGTM, thanks!
351 i18n-values="aria-label:DELETE_BUTTON_LABEL"	351 i18n-values="aria-label:DELETE_BUTTON_LABEL"

352 visibleif="full-page">	352 visibleif="full-page">

353 <paper-ripple fit class="recenteringTouch circle"></paper-ripple>	353 <paper-ripple fit class="recenteringTouch circle"></paper-ripple>

354 </button>	354 </button>

355 <button id="cloud-import-button"	355 <button id="cloud-import-button"

356 class="icon-button manual-display"	356 class="icon-button manual-display"

357 tabindex="11"	357 tabindex="11"

358 i18n-values="aria-label:CLOUD_IMPORT_COMMAND"	358 i18n-values="aria-label:CLOUD_IMPORT_COMMAND"

359 hidden>	359 hidden>

360 <core-icon icon="cloud-queue"></core-icon>	360 <core-icon icon="cloud-queue"></core-icon>

(...skipping 116 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
477 <div class="right buttonbar">	477 <div class="right buttonbar">

478 <select class="file-type" hidden></select>	478 <select class="file-type" hidden></select>

479 <paper-button class="cancel secondary" i18n-content="CANCEL_LABEL" tabin dex="3"></paper-button>	479 <paper-button class="cancel secondary" i18n-content="CANCEL_LABEL" tabin dex="3"></paper-button>

480 <paper-button class="ok primary" disabled tabindex="2"></paper-button>	480 <paper-button class="ok primary" disabled tabindex="2"></paper-button>

481 </div>	481 </div>

482 </div>	482 </div>

483 <div id="drag-container"></div>	483 <div id="drag-container"></div>

484 <iframe id="command-dispatcher" hidden></iframe>	484 <iframe id="command-dispatcher" hidden></iframe>

485 </body>	485 </body>

486 </html>	486 </html>

OLD	NEW

« ui/file_manager/file_manager/foreground/js/toolbar_controller.js ('K') | « ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js ('k') | no next file » | no next file with comments »