Files.app: Make delete button on the toolbar standard button instead of CommandButton.

Files.app: Make delete button on the toolbar standard button instead of CommandButton.

The period "Delete button should be shown" is not exactly same as "Delete command can be executed."
For example: While a confirm dialog overlays Files.app, the dialog consumes all input event so the delete command cannot be executed, but still the delete button should be shown under the overlaying dialog.

BUG=459402, 457113
TEST=manually checked the repro steps on each issue.

Committed: https://crrev.com/2b5fc4b664d47828d4e999a0fb17b22038318864
Cr-Commit-Position: refs/heads/master@{#317569}

[fukino, 2015-02-23 09:40:51]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2015-02-23 09:40:52]

Could you take a look? Thank you!

[hirono, 2015-02-23 09:48:37]

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/toolbar_controller.js (right):

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:21: /**
@private {!HTMLElement} */
nit: We would like to add @const for member variables that are not reassigned.

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/main.html:350: <button id="delete-button"
class="icon-button" tabindex="10"
Can we make this paper-button?

[fukino, 2015-02-23 11:18:50]

Thank you!

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/toolbar_controller.js (right):

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/toolbar_controller.js:21: /**
@private {!HTMLElement} */
On 2015/02/23 09:48:37, hirono wrote:
> nit: We would like to add @const for member variables that are not reassigned.

Done.

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/main.html:350: <button id="delete-button"
class="icon-button" tabindex="10"
On 2015/02/23 09:48:37, hirono wrote:
> Can we make this paper-button?

We could you <paper-icon-button> for buttons on the toolbar, but for now other
non-command buttons don't use <paper-icon-button>. I wanted to keep using
<button> for consistency and for safety to merge this to M42. WDYT?

[hirono, 2015-02-23 11:23:51]

lgtm!

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/951443002/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/main.html:350: <button id="delete-button"
class="icon-button" tabindex="10"
On 2015/02/23 11:18:50, fukino wrote:
> On 2015/02/23 09:48:37, hirono wrote:
> > Can we make this paper-button?
> 
> We could you <paper-icon-button> for buttons on the toolbar, but for now other
> non-command buttons don't use <paper-icon-button>. I wanted to keep using
> <button> for consistency and for safety to merge this to M42. WDYT?

SGTM, thanks!

[fukino, 2015-02-23 11:32:58]

Thank you!

[fukino, 2015-02-23 11:33:05]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2015-02-23 11:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951443002/60001

[commit-bot: I haz the power, 2015-02-23 11:56:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-23 11:57:15]

Patchset 4 (id:??) landed as
https://crrev.com/2b5fc4b664d47828d4e999a0fb17b22038318864
Cr-Commit-Position: refs/heads/master@{#317569}