Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 951423003: Revert of Fixes for two different HUD issues related to win32k lockdown (patchset #9 id:350001 of h… (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
danakj, enne (OOO), piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Revert of Fixes for two different HUD issues related to win32k lockdown (patchset #9 id:350001 of https://codereview.chromium.org/900063002/) Reason for revert: Causes regression in cold start on Android and maybe Mac. Details in http://crbug.com/457248. Original issue's description: > Fixes for two different HUD issues related to win32k lockdown > > 1. Using a GDI bitmap -- switch to SkSurface instead > > 2. Lazily loading a font. This breaks for two different reasons. > The first is a DCHECK for doing IO on the Compositor thread. This > could have been just ignored in general since it's only for debug > usage, the drawbacks of minor jank are limited. > > However, once lockdown is on, the font load hard fails from the > renderer. So, load the typeface before lockdown and pass it into > CC and the hud via LayerTreeSettings. > > R=danakj@chromium.org > BUG=453731, 455104 > TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8 > > Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799 > Cr-Commit-Position: refs/heads/master@{#314929} TBR=enne@chromium.org,danakj@chromium.org,piman@chromium.org BUG=453731, 455104, 457248 Review URL: https://codereview.chromium.org/922293006 Cr-Commit-Position: refs/heads/master@{#317648} (cherry picked from commit 1793e0467bb34d2545c0493a557bb038cc2ac6f0) Committed: https://chromium.googlesource.com/chromium/src/+/f95981fc5a6371498d5e675b3cd13014303b6084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -90 lines) Patch
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 4 chunks +17 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/hud_font.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/hud_font.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scottmg
5 years, 10 months ago (2015-02-25 17:25:19 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f95981fc5a6371498d5e675b3cd13014303b6084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698