Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 922293006: Revert of Fixes for two different HUD issues related to win32k lockdown (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
danakj, enne (OOO), piman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixes for two different HUD issues related to win32k lockdown (patchset #9 id:350001 of https://codereview.chromium.org/900063002/) Reason for revert: Causes regression in cold start on Android and maybe Mac. Details in http://crbug.com/457248. Original issue's description: > Fixes for two different HUD issues related to win32k lockdown > > 1. Using a GDI bitmap -- switch to SkSurface instead > > 2. Lazily loading a font. This breaks for two different reasons. > The first is a DCHECK for doing IO on the Compositor thread. This > could have been just ignored in general since it's only for debug > usage, the drawbacks of minor jank are limited. > > However, once lockdown is on, the font load hard fails from the > renderer. So, load the typeface before lockdown and pass it into > CC and the hud via LayerTreeSettings. > > R=danakj@chromium.org > BUG=453731, 455104 > TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8 > > Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799 > Cr-Commit-Position: refs/heads/master@{#314929} TBR=enne@chromium.org,danakj@chromium.org,piman@chromium.org BUG=453731, 455104, 457248 Committed: https://chromium.googlesource.com/chromium/src/+/1793e0467bb34d2545c0493a557bb038cc2ac6f0

Patch Set 1 #

Patch Set 2 : resolve conflicts #

Patch Set 3 : fix merge #

Patch Set 4 : test #

Patch Set 5 : sigh #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -90 lines) Patch
M cc/layers/heads_up_display_layer_impl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 2 3 4 5 4 chunks +17 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 2 chunks +1 line, -9 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 chunks +2 lines, -6 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/hud_font.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/hud_font.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
scottmg
Created Revert of Fixes for two different HUD issues related to win32k lockdown
5 years, 10 months ago (2015-02-23 16:41:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/1
5 years, 10 months ago (2015-02-23 16:42:10 UTC) #2
commit-bot: I haz the power
Failed to apply patch for cc/layers/heads_up_display_layer_impl.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-23 16:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/230001
5 years, 10 months ago (2015-02-23 17:35:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/250001
5 years, 10 months ago (2015-02-23 18:47:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61800)
5 years, 10 months ago (2015-02-23 18:51:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/250001
5 years, 10 months ago (2015-02-23 18:56:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/180002
5 years, 10 months ago (2015-02-23 19:04:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61820)
5 years, 10 months ago (2015-02-23 19:07:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/270001
5 years, 10 months ago (2015-02-23 19:25:00 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61846)
5 years, 10 months ago (2015-02-23 19:30:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/270001
5 years, 10 months ago (2015-02-23 19:53:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293006/250002
5 years, 10 months ago (2015-02-23 20:26:19 UTC) #27
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/1793e0467bb34d2545c0493a557bb038cc2ac6f0 Cr-Commit-Position: refs/heads/master@{#317648}
5 years, 10 months ago (2015-02-23 21:10:02 UTC) #28
scottmg
5 years, 10 months ago (2015-02-23 21:10:14 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:250002) manually as
1793e0467bb34d2545c0493a557bb038cc2ac6f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698