Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 951303003: Added basic client hints support. (Closed)

Created:
5 years, 10 months ago by Yoav Weiss
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added basic client hints support. This CL adds basic client hints support for the DPR and RW hints. It also includes an "Accept-CH" based opt-in mechanism. It does not include: * A decent Accept-CH parser * Actual Resource width being sent as the RW header BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190831

Patch Set 1 #

Total comments: 5

Patch Set 2 : Review comments #

Total comments: 3

Patch Set 3 : Removed expected files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -10 lines) Patch
A LayoutTests/http/tests/misc/client-hints-accept.php View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/client-hints-no-accept.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/resources/image-checks-for-dpr.php View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/resources/image-checks-for-rw.php View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 3 chunks +15 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcherTest.cpp View 1 8 chunks +75 lines, -7 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (3 generated)
Yoav Weiss
5 years, 10 months ago (2015-02-24 13:04:06 UTC) #2
Mike West
On 2015/02/24 at 13:04:06, yoav wrote: > I'm not going to have time to look ...
5 years, 10 months ago (2015-02-24 13:05:24 UTC) #3
Yoav Weiss
On 2015/02/24 13:05:24, Mike West wrote: > On 2015/02/24 at 13:04:06, yoav wrote: > > ...
5 years, 10 months ago (2015-02-24 13:48:43 UTC) #4
Mike West
Looking good! A few questions. https://codereview.chromium.org/951303003/diff/1/Source/core/fetch/Resource.cpp File Source/core/fetch/Resource.cpp (right): https://codereview.chromium.org/951303003/diff/1/Source/core/fetch/Resource.cpp#newcode449 Source/core/fetch/Resource.cpp:449: // FIXME: Write an ...
5 years, 10 months ago (2015-02-25 09:03:14 UTC) #5
Mike West
https://codereview.chromium.org/951303003/diff/1/LayoutTests/http/tests/misc/client-hints-accept.php File LayoutTests/http/tests/misc/client-hints-accept.php (right): https://codereview.chromium.org/951303003/diff/1/LayoutTests/http/tests/misc/client-hints-accept.php#newcode9 LayoutTests/http/tests/misc/client-hints-accept.php:9: <img src="resources/image-checks-for-dpr.php" onload="console.log('DPR sent.')" onerror="console.log('DPR not sent.')"> Ditto. https://codereview.chromium.org/951303003/diff/1/LayoutTests/http/tests/misc/client-hints-no-accept.html ...
5 years, 10 months ago (2015-02-25 09:06:08 UTC) #6
Yoav Weiss
On 2015/02/25 09:03:14, Mike West wrote: > Looking good! A few questions. > > https://codereview.chromium.org/951303003/diff/1/Source/core/fetch/Resource.cpp ...
5 years, 10 months ago (2015-02-25 09:14:49 UTC) #7
Yoav Weiss
On 2015/02/25 09:06:08, Mike West wrote: > https://codereview.chromium.org/951303003/diff/1/LayoutTests/http/tests/misc/client-hints-accept.php > File LayoutTests/http/tests/misc/client-hints-accept.php (right): > > https://codereview.chromium.org/951303003/diff/1/LayoutTests/http/tests/misc/client-hints-accept.php#newcode9 ...
5 years, 10 months ago (2015-02-25 09:15:23 UTC) #8
Yoav Weiss
On 2015/02/25 09:03:14, Mike West wrote: > > https://codereview.chromium.org/951303003/diff/1/Source/core/fetch/Resource.cpp > File Source/core/fetch/Resource.cpp (right): > > ...
5 years, 10 months ago (2015-02-25 09:24:04 UTC) #9
Mike West
On 2015/02/25 at 09:24:04, yoav wrote: > On 2015/02/25 09:03:14, Mike West wrote: > > ...
5 years, 10 months ago (2015-02-25 09:27:56 UTC) #10
Yoav Weiss
On 2015/02/25 09:27:56, Mike West wrote: > On 2015/02/25 at 09:24:04, yoav wrote: > > ...
5 years, 10 months ago (2015-02-25 09:33:53 UTC) #11
Yoav Weiss
On 2015/02/25 09:33:53, Yoav Weiss wrote: > On 2015/02/25 09:27:56, Mike West wrote: > > ...
5 years, 10 months ago (2015-02-25 11:04:11 UTC) #12
Mike West
LGTM % test comments. https://codereview.chromium.org/951303003/diff/20001/LayoutTests/http/tests/misc/client-hints-no-accept-expected.txt File LayoutTests/http/tests/misc/client-hints-no-accept-expected.txt (right): https://codereview.chromium.org/951303003/diff/20001/LayoutTests/http/tests/misc/client-hints-no-accept-expected.txt#newcode3 LayoutTests/http/tests/misc/client-hints-no-accept-expected.txt:3: PASS Client-Hints not sent when ...
5 years, 10 months ago (2015-02-25 11:37:12 UTC) #13
Yoav Weiss
On 2015/02/25 11:37:12, Mike West wrote: > LGTM % test comments. > > https://codereview.chromium.org/951303003/diff/20001/LayoutTests/http/tests/misc/client-hints-no-accept-expected.txt > ...
5 years, 10 months ago (2015-02-25 11:59:50 UTC) #14
Yoav Weiss
On 2015/02/25 11:59:50, Yoav Weiss wrote: > On 2015/02/25 11:37:12, Mike West wrote: > > ...
5 years, 10 months ago (2015-02-25 12:10:56 UTC) #15
Mike West
Wunderbar. Land it. :)
5 years, 10 months ago (2015-02-25 12:36:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951303003/40001
5 years, 10 months ago (2015-02-25 13:02:58 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 14:29:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190831

Powered by Google App Engine
This is Rietveld 408576698