LayoutTests/http/tests/misc/client-hints-no-accept.html - Issue 951303003: Added basic client hints support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/misc/client-hints-no-accept.html

Issue 951303003: Added basic client hints support. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="/w3c/resources/testharness.js"></script>

	3 <script src="/w3c/resources/testharnessreport.js"></script>

	4 <body>

	5 <script>

	6 var t = async_test('Client-Hints not sent when Aceept-CH header is not p resent');
	Mike West 2015/02/25 11:37:11 Nit: s/Aceept/Accept/ Nit: s/Aceept/Accept/
	7 var body = document.body;

	8 var unreached = function() {

	9 assert_unreached("Image should not have loaded.");

	10 };

	11

	12 var loadRWImage = function() {

	13 var img = new Image();

	14 img.src = 'resources/image-checks-for-rw.php';

	15 img.onload = t.step_func(unreached);

	16 img.onerror = t.step_func(function(){ t.done(); });

	17 body.appendChild(img);

	18 };

	19 t.step(function() {

	20 var img = new Image();

	21 img.src = 'resources/image-checks-for-dpr.php';
	Mike West 2015/02/25 11:37:11 Doesn't assigning to `.src` trigger a load right a Doesn't assigning to `.src` trigger a load right away? I've always put the `onload`/`onerror` bits above the assignment for that reason. But I guess you know better than I...
	22 img.onload = t.step_func(unreached);

	23 img.onerror = t.step_func(loadRWImage);

	24 body.appendChild(img);

	25 });

	26 </script>

	27 </body>

OLD	NEW