Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 951083003: xp: copy dbghelp.dll to output dir and have base.isolate use it there (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

xp: copy dbghelp.dll to output dir and have base.isolate use it there Previous CL https://codereview.chromium.org/943933005 didn't work properly because the dll wasn't in the same directory as the binary, so it was still loading the system dbghelp.dll. See details in 460506. Copies dbghelp.dll to the output dir, and has the isolate file point at that. Re-enable tests that were failing due to dbghelp hanging. XP test run here: https://chromium-swarm.appspot.com/user/task/25d5bc17b6dddc10 BUG=460506, 461160 Committed: https://crrev.com/09acc50cfadc6aa38db23ddadec134410ec968c0 Cr-Commit-Position: refs/heads/master@{#317868} Committed: https://crrev.com/f063a7eb8a746bc2479509664d26e193e35b6957 Cr-Commit-Position: refs/heads/master@{#317926}

Patch Set 1 #

Patch Set 2 : try removing dll #

Patch Set 3 : see if plog helps #

Patch Set 4 : try different test, readd dll #

Patch Set 5 : xp: copy dbghelp.dll to output dir and have base.isolate use it there #

Patch Set 6 : . #

Patch Set 7 : put copy in 'base', not 'base_unittests' #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M base/base.gyp View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M base/base.isolate View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/debug/debugger_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/debug/stack_trace_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
scottmg
5 years, 10 months ago (2015-02-24 18:49:49 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-24 18:57:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951083003/100001
5 years, 10 months ago (2015-02-24 19:03:38 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-24 20:18:36 UTC) #6
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/09acc50cfadc6aa38db23ddadec134410ec968c0 Cr-Commit-Position: refs/heads/master@{#317868}
5 years, 10 months ago (2015-02-24 20:20:03 UTC) #7
scottmg
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/954003002/ by scottmg@chromium.org. ...
5 years, 10 months ago (2015-02-24 22:21:12 UTC) #8
scottmg
Reverted, and relanding -- I put the dll copy in 'base_unittests', not 'base', so it ...
5 years, 10 months ago (2015-02-24 22:46:18 UTC) #9
scottmg
Diff from 6->7 is the change for reland, going to add a rebase as ps8+.
5 years, 10 months ago (2015-02-24 22:47:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951083003/140001
5 years, 10 months ago (2015-02-24 23:30:00 UTC) #13
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 10 months ago (2015-02-25 00:17:42 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 00:20:02 UTC) #15
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/f063a7eb8a746bc2479509664d26e193e35b6957
Cr-Commit-Position: refs/heads/master@{#317926}

Powered by Google App Engine
This is Rietveld 408576698