Descriptionxp: copy dbghelp.dll to output dir and have base.isolate use it there
Previous CL https://codereview.chromium.org/943933005 didn't work properly
because the dll wasn't in the same directory as the binary, so it was still
loading the system dbghelp.dll. See details in 460506.
Copies dbghelp.dll to the output dir, and has the isolate file point at that.
Re-enable tests that were failing due to dbghelp hanging.
XP test run here: https://chromium-swarm.appspot.com/user/task/25d5bc17b6dddc10
BUG=460506, 461160
Committed: https://crrev.com/09acc50cfadc6aa38db23ddadec134410ec968c0
Cr-Commit-Position: refs/heads/master@{#317868}
Committed: https://crrev.com/f063a7eb8a746bc2479509664d26e193e35b6957
Cr-Commit-Position: refs/heads/master@{#317926}
Patch Set 1 #Patch Set 2 : try removing dll #Patch Set 3 : see if plog helps #Patch Set 4 : try different test, readd dll #Patch Set 5 : xp: copy dbghelp.dll to output dir and have base.isolate use it there #Patch Set 6 : . #Patch Set 7 : put copy in 'base', not 'base_unittests' #Patch Set 8 : rebase #
Messages
Total messages: 15 (4 generated)
|