build/android/pylib/remote/device/remote_device_environment.py - Issue 950893004: Add exit code for infra failures to testrunner script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/remote/device/remote_device_environment.py

Issue 950893004: Add exit code for infra failures to testrunner script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made CL more general. BaseError now has is_infra_error property. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/base/base_error.py ('K') | « build/android/pylib/device/device_utils.py ('k') | build/android/pylib/remote/device/remote_device_helper.py » ('j') | build/android/test_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/remote/device/remote_device_environment.py

diff --git a/build/android/pylib/remote/device/remote_device_environment.py b/build/android/pylib/remote/device/remote_device_environment.py

index 256118098f409c1f622a76300e51be53817f4095..3d76efda0383b6cbd8420be68a25fd6ae29f8075 100644

--- a/build/android/pylib/remote/device/remote_device_environment.py

+++ b/build/android/pylib/remote/device/remote_device_environment.py

@@ -302,7 +302,8 @@ class RemoteDeviceEnvironment(environment.Environment):

def _NoDeviceFound(self):

self._PrintAvailableDevices(self._GetDeviceList())

- raise remote_device_helper.RemoteDeviceError('No device found.')

+ raise remote_device_helper.RemoteDeviceError('No device found.',

jbudorick 2015/02/23 22:13:00 Either: - put a parameter on the first line and i

mikecase (-- gone --) 2015/02/23 22:29:27 Done.

+ is_infra_error=True)

@property

def collect(self):