build/android/pylib/device/device_utils.py - Issue 950893004: Add exit code for infra failures to testrunner script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/device_utils.py

Issue 950893004: Add exit code for infra failures to testrunner script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made CL more general. BaseError now has is_infra_error property. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/base/base_error.py ('K') | « build/android/pylib/device/device_errors.py ('k') | build/android/pylib/remote/device/remote_device_environment.py » ('j') | build/android/pylib/remote/device/remote_device_environment.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/device/device_utils.py

diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py

index fb882e73b85008a1b66a24758a34f64e060a7fdb..a8eb3edcc3ff556463796fc38d147953f4d43da2 100644

--- a/build/android/pylib/device/device_utils.py

+++ b/build/android/pylib/device/device_utils.py

@@ -22,6 +22,7 @@ import zipfile

import pylib.android_commands

from pylib import cmd_helper

from pylib import constants

+from pylib.base import base_error

from pylib.device import adb_wrapper

from pylib.device import decorators

from pylib.device import device_errors

@@ -159,7 +160,7 @@ class DeviceUtils(object):

"""

try:

return self.adb.GetState() == 'device'

- except device_errors.BaseError as exc:

+ except base_error.BaseError as exc:

logging.info('Failed to get state: %s', exc)

return False