Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 950893002: Mark Attr.ownerElement as nullable (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark Attr.ownerElement as nullable No change to generated code, as there are no checks to verify that a non-nullable return type is never null. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/dom/Attr.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL. I should have done this in https://codereview.chromium.org/942283002 since there are no actual changes.
5 years, 10 months ago (2015-02-23 16:48:30 UTC) #2
Jens Widell
LGTM
5 years, 10 months ago (2015-02-23 16:54:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950893002/1
5 years, 10 months ago (2015-02-24 01:56:26 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 02:00:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190710

Powered by Google App Engine
This is Rietveld 408576698