Chromium Code Reviews

Issue 942283002: Sync the Attr interface with the spec (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
haraken, leviw_travelin_and_unemployed, jsbell, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : crbug #

Unified diffs Side-by-side diffs Stats (+12 lines, -16 lines)
M Source/core/dom/Attr.idl View 1 chunk +12 lines, -16 lines 0 comments

Messages

Total messages: 7 (2 generated)
philipj_slow
crbug
5 years, 10 months ago (2015-02-21 18:29:33 UTC) #1
philipj_slow
Hi all, you responded to blink-dev, so PTAL at this first CL :)
5 years, 10 months ago (2015-02-21 18:47:13 UTC) #3
haraken
LGTM
5 years, 10 months ago (2015-02-21 22:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942283002/20001
5 years, 10 months ago (2015-02-22 03:37:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-22 05:21:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190621

Powered by Google App Engine