Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 950833002: Updating gypi after moving FocusType.h. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Updating gypi after moving FocusType.h. Source/core/page/FocusType was moved to public/WebFocusType.h in https://codereview.chromium.org/852083002 This updates the gypi file to reflect that change and to avoid a warning in the msvs-ninja gyp generator. Note: there is no gypi file that tracks the files in public/platform. R=fsamuel@chromium.org,jochen@chromium.org BUG=448716, 147644, 459058 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Daniel Bratell
5 years, 10 months ago (2015-02-23 13:08:11 UTC) #1
Fady Samuel
lgtm
5 years, 10 months ago (2015-02-23 15:41:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-23 16:19:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950833002/1
5 years, 10 months ago (2015-02-23 17:34:23 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:16:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190679

Powered by Google App Engine
This is Rietveld 408576698