Issue 950813002: [XHR] Add layout tests to see the cause of a flaky test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 950813002: [XHR] Add layout tests to see the cause of a flaky test. (Closed)

Created:
5 years, 10 months ago by yhirano

Modified:
5 years, 10 months ago

Reviewers:
hiroshige

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[XHR] Add layout tests to see the cause of a flaky test. http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html is flaky, but I cannot reproduce it and don't see any cause. To understand the problem, this CL adds two more layout tests. R=hiroshige BUG=415872 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190652

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-sync.html	View	1 chunk	+2 lines, -4 lines	0 comments	Download
A +	LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-sync-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950813002/1

5 years, 10 months ago (2015-02-23 10:45:42 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 13:06:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190652

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages