LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html - Issue 950813002: [XHR] Add layout tests to see the cause of a flaky test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html

Issue 950813002: [XHR] Add layout tests to see the cause of a flaky test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-sync-expected.txt ('k') | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html

diff --git a/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html b/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html

similarity index 89%

copy from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html

copy to LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html

index 0f0b4f38b47aa270d1437e38b7f55764c44eb4af..185982cc89e7fd7441518672d4efbe4d6da4e7a1 100644

--- a/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort.html

+++ b/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-abort-timer.html

@@ -8,10 +8,10 @@ xhr.responseType = 'document';

xhr.onreadystatechange = function () {

if (this.readyState == XMLHttpRequest.LOADING) {

xhr.abort();

- requestAnimationFrame(function() {

+ setTimeout(function() {

debug("PASS if no crash or leak.");

testRunner.notifyDone();

- });

+ }, 0);

}

};