Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 950773003: Improve 2D Canvas Text Metrics Test (Closed)

Created:
5 years, 10 months ago by Dominik Röttsches
Modified:
5 years, 9 months ago
Reviewers:
sugoi, jbroman, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve 2D Canvas Text Metrics Test Instead of a somewhat arbitrary timeout which may introduce flakiness and trying to force the font load through an HTML element using the font, I suggest to use explicit font loading events. CanvasTest.ttf only contains test glyphs for [A-E], the test strings "Some Text", "M", "q" will use fallback fonts which lead to platform specific variations. Since this was never an original Philip Canvas Text, I think it's okay to load a web font explicitly from outside the Philip suite. BUG=460866 R=sugoi,eae,jbroman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192429

Patch Set 1 #

Patch Set 2 : Additional rebaselines for virtual suites #

Patch Set 3 : Rebaselined TestExpectations #

Patch Set 4 : Adding missing endTest() statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/canvas/philip/tests/2d.text.draw.text.metrics.html View 1 2 3 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dominik Röttsches
5 years, 10 months ago (2015-02-23 12:13:30 UTC) #1
eae
LGTM
5 years, 10 months ago (2015-02-23 18:40:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950773003/20001
5 years, 10 months ago (2015-02-23 18:41:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/44179)
5 years, 10 months ago (2015-02-23 18:51:54 UTC) #6
Dominik Röttsches
Rebaselined TestExpectations
5 years, 10 months ago (2015-02-24 08:47:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950773003/40001
5 years, 10 months ago (2015-02-24 09:22:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/52082)
5 years, 10 months ago (2015-02-24 11:55:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950773003/60001
5 years, 9 months ago (2015-03-24 12:44:02 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:47:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192429

Powered by Google App Engine
This is Rietveld 408576698