Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 950523003: MIPS: Fix 'MIPS: Move Maps' back pointers from "transitions" to "constructor" field'. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'MIPS: Move Maps' back pointers from "transitions" to "constructor" field'. BUG= Committed: https://crrev.com/296b5b0e3aeb61dc3b0c21844d3b925a5f1092fb Cr-Commit-Position: refs/heads/master@{#26860}

Patch Set 1 #

Patch Set 2 : Remove DCHECK lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
balazs.kilvady
5 years, 9 months ago (2015-02-25 16:11:10 UTC) #3
Jakob Kummerow
Looks good to me (but deferring approval to Paul).
5 years, 9 months ago (2015-02-25 16:12:58 UTC) #4
paul.l...
Thanks Jakob, for the suggestion and reviews! LGTM.
5 years, 9 months ago (2015-02-25 16:16:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950523003/20001
5 years, 9 months ago (2015-02-25 16:18:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-25 16:41:54 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 16:42:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/296b5b0e3aeb61dc3b0c21844d3b925a5f1092fb
Cr-Commit-Position: refs/heads/master@{#26860}

Powered by Google App Engine
This is Rietveld 408576698