Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 950523003: MIPS: Fix 'MIPS: Move Maps' back pointers from "transitions" to "constructor" field'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove DCHECK lines. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2641 matching lines...) Expand 10 before | Expand all | Expand 10 after
2652 __ GetObjectType(input, temp, temp2); 2652 __ GetObjectType(input, temp, temp2);
2653 __ Subu(temp2, temp2, Operand(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE)); 2653 __ Subu(temp2, temp2, Operand(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));
2654 __ Branch(is_false, gt, temp2, Operand(LAST_NONCALLABLE_SPEC_OBJECT_TYPE - 2654 __ Branch(is_false, gt, temp2, Operand(LAST_NONCALLABLE_SPEC_OBJECT_TYPE -
2655 FIRST_NONCALLABLE_SPEC_OBJECT_TYPE)); 2655 FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));
2656 } 2656 }
2657 2657
2658 // Now we are in the FIRST-LAST_NONCALLABLE_SPEC_OBJECT_TYPE range. 2658 // Now we are in the FIRST-LAST_NONCALLABLE_SPEC_OBJECT_TYPE range.
2659 // Check if the constructor in the map is a function. 2659 // Check if the constructor in the map is a function.
2660 Register instance_type = scratch1(); 2660 Register instance_type = scratch1();
2661 DCHECK(!instance_type.is(temp)); 2661 DCHECK(!instance_type.is(temp));
2662 DCHECK(!instance_type.is(temp2));
2663 __ GetMapConstructor(temp, temp, temp2, instance_type); 2662 __ GetMapConstructor(temp, temp, temp2, instance_type);
2664 2663
2665 // Objects with a non-function constructor have class 'Object'. 2664 // Objects with a non-function constructor have class 'Object'.
2666 if (String::Equals(class_name, isolate()->factory()->Object_string())) { 2665 if (String::Equals(class_name, isolate()->factory()->Object_string())) {
2667 __ Branch(is_true, ne, instance_type, Operand(JS_FUNCTION_TYPE)); 2666 __ Branch(is_true, ne, instance_type, Operand(JS_FUNCTION_TYPE));
2668 } else { 2667 } else {
2669 __ Branch(is_false, ne, instance_type, Operand(JS_FUNCTION_TYPE)); 2668 __ Branch(is_false, ne, instance_type, Operand(JS_FUNCTION_TYPE));
2670 } 2669 }
2671 2670
2672 // temp now contains the constructor function. Grab the 2671 // temp now contains the constructor function. Grab the
(...skipping 3360 matching lines...) Expand 10 before | Expand all | Expand 10 after
6033 __ li(at, scope_info); 6032 __ li(at, scope_info);
6034 __ Push(at, ToRegister(instr->function())); 6033 __ Push(at, ToRegister(instr->function()));
6035 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6034 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6036 RecordSafepoint(Safepoint::kNoLazyDeopt); 6035 RecordSafepoint(Safepoint::kNoLazyDeopt);
6037 } 6036 }
6038 6037
6039 6038
6040 #undef __ 6039 #undef __
6041 6040
6042 } } // namespace v8::internal 6041 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698