Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js

Issue 950433002: Fix a crash when processing an invalid PAC script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback from mmenke Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js
diff --git a/net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js b/net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js
new file mode 100644
index 0000000000000000000000000000000000000000..1b47336667a5649db563aee6f5989ed64b3b552c
--- /dev/null
+++ b/net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js
@@ -0,0 +1,8 @@
+// This PAC script will throw an exception when accessing the
+// "FindProxyForURL" property.
+
+function FindProxyForURLGetter() {
mmenke 2015/02/20 22:15:05 nit: f should be lowercase, I believe.
eroman 2015/02/20 22:24:23 In my mind "FindProxyForURL" is the target object,
+ throw "crash!";
+}
+
+Object.defineProperty(this, "FindProxyForURL", {get: FindProxyForURLGetter});

Powered by Google App Engine
This is Rietveld 408576698