net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js - Issue 950433002: Fix a crash when processing an invalid PAC script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js

Issue 950433002: Fix a crash when processing an invalid PAC script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from mmenke Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js ('K') | « net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_init.js ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | net/proxy/proxy_resolver_v8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js

diff --git a/net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js b/net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js

new file mode 100644

index 0000000000000000000000000000000000000000..965a79fa152e9dcae1603379f3629467811ed407

--- /dev/null

+++ b/net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js

@@ -0,0 +1,17 @@

+// This PAC script will throw an exception when accessing the "FindProxyForURL"

+// the *second* time it is accessed.

+function actualFindProxyForURL(url, host) {

+ return "DIRECT";

+var counter = 2;

+function FindProxyForURLGetter() {

mmenke 2015/02/20 22:15:05 nit: f should be lowercase, I believe.

+ counter--;

+ if (counter <= 0)

+ throw "crash!";

+ return actualFindProxyForURL;

+Object.defineProperty(this, "FindProxyForURL", {get: FindProxyForURLGetter});