Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 950223006: Fix RenderFrameHostChanged WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove leftover log and empty lines Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 15338be2d0de70f6d680a0daf3b0359aa460b58d..b6e03af32ce5931fcdab130173168871f2b6d9af 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -137,6 +137,11 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
virtual void NotifySwappedFromRenderManager(RenderFrameHost* old_host,
RenderFrameHost* new_host,
bool is_main_frame) = 0;
+ // TODO(nasko): This should be removed once extensions no longer use
+ // NotificationService. See https://crbug.com/462682
Charlie Reis 2015/03/02 18:38:26 nit: End with period.
nasko 2015/03/02 19:30:54 Done.
+ virtual void NotifyMainFrameSwappedFromRenderManager(
+ RenderFrameHost* old_host,
+ RenderFrameHost* new_host) = 0;
Charlie Reis 2015/03/02 18:38:26 I feel like it's worth using RVH here instead of R
nasko 2015/03/02 19:30:54 Done.
virtual NavigationControllerImpl&
GetControllerForRenderManager() = 0;

Powered by Google App Engine
This is Rietveld 408576698