Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 950223006: Fix RenderFrameHostChanged WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove leftover log and empty lines Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 virtual void BeforeUnloadFiredFromRenderManager( 130 virtual void BeforeUnloadFiredFromRenderManager(
131 bool proceed, const base::TimeTicks& proceed_time, 131 bool proceed, const base::TimeTicks& proceed_time,
132 bool* proceed_to_fire_unload) = 0; 132 bool* proceed_to_fire_unload) = 0;
133 virtual void RenderProcessGoneFromRenderManager( 133 virtual void RenderProcessGoneFromRenderManager(
134 RenderViewHost* render_view_host) = 0; 134 RenderViewHost* render_view_host) = 0;
135 virtual void UpdateRenderViewSizeForRenderManager() = 0; 135 virtual void UpdateRenderViewSizeForRenderManager() = 0;
136 virtual void CancelModalDialogsForRenderManager() = 0; 136 virtual void CancelModalDialogsForRenderManager() = 0;
137 virtual void NotifySwappedFromRenderManager(RenderFrameHost* old_host, 137 virtual void NotifySwappedFromRenderManager(RenderFrameHost* old_host,
138 RenderFrameHost* new_host, 138 RenderFrameHost* new_host,
139 bool is_main_frame) = 0; 139 bool is_main_frame) = 0;
140 // TODO(nasko): This should be removed once extensions no longer use
141 // NotificationService. See https://crbug.com/462682
Charlie Reis 2015/03/02 18:38:26 nit: End with period.
nasko 2015/03/02 19:30:54 Done.
142 virtual void NotifyMainFrameSwappedFromRenderManager(
143 RenderFrameHost* old_host,
144 RenderFrameHost* new_host) = 0;
Charlie Reis 2015/03/02 18:38:26 I feel like it's worth using RVH here instead of R
nasko 2015/03/02 19:30:54 Done.
140 virtual NavigationControllerImpl& 145 virtual NavigationControllerImpl&
141 GetControllerForRenderManager() = 0; 146 GetControllerForRenderManager() = 0;
142 147
143 // Create swapped out RenderViews in the given SiteInstance for each tab in 148 // Create swapped out RenderViews in the given SiteInstance for each tab in
144 // the opener chain of this tab, if any. This allows the current tab to 149 // the opener chain of this tab, if any. This allows the current tab to
145 // make cross-process script calls to its opener(s). Returns the route ID 150 // make cross-process script calls to its opener(s). Returns the route ID
146 // of the immediate opener, if one exists (otherwise MSG_ROUTING_NONE). 151 // of the immediate opener, if one exists (otherwise MSG_ROUTING_NONE).
147 virtual int CreateOpenerRenderViewsForRenderManager( 152 virtual int CreateOpenerRenderViewsForRenderManager(
148 SiteInstance* instance) = 0; 153 SiteInstance* instance) = 0;
149 154
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
688 bool should_reuse_web_ui_; 693 bool should_reuse_web_ui_;
689 694
690 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 695 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
691 696
692 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 697 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
693 }; 698 };
694 699
695 } // namespace content 700 } // namespace content
696 701
697 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 702 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698