Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 950113002: Backport PNG output format to origin/master branch. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Backport PNG output format to origin/master branch. The pdfium library itself does not support the format, but the test utility can convert to this output format. GN build can't be tested standalone, so push this out to the next CL. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ef1e85caf492e1b9bf9803647d3c5db1abea77c7

Patch Set 1 #

Patch Set 2 : Postpone GN for the moment. #

Patch Set 3 : Add missing image_diff files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38874 lines, -122 lines) Patch
A + samples/fx_lpng/include/fx_png.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_png.c View 1 2 1 chunk +4297 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngerror.c View 1 2 1 chunk +931 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngget.c View 1 2 1 chunk +1176 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngmem.c View 1 2 1 chunk +289 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngpread.c View 1 2 1 chunk +1290 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngread.c View 1 2 1 chunk +3999 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngrio.c View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngrtran.c View 1 2 1 chunk +5102 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngrutil.c View 1 2 1 chunk +4471 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngset.c View 1 2 1 chunk +1596 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngtrans.c View 1 2 1 chunk +840 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngwio.c View 1 2 1 chunk +163 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngwrite.c View 1 2 1 chunk +2329 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngwtran.c View 1 2 1 chunk +636 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/fx_pngwutil.c View 1 2 1 chunk +3022 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/png.h View 1 2 1 chunk +3566 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/pngconf.h View 1 2 1 chunk +617 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/pngdebug.h View 1 2 1 chunk +157 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/pnginfo.h View 1 2 1 chunk +260 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/pnglibconf.h View 1 2 1 chunk +211 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/pngpriv.h View 1 2 1 chunk +2006 lines, -0 lines 0 comments Download
A samples/fx_lpng/lpng_v163/pngstruct.h View 1 2 1 chunk +489 lines, -0 lines 0 comments Download
A + samples/fx_lpng/src/fx_png.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngerror.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngget.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngmem.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngpread.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngread.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngrio.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngrtran.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngrutil.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngset.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngtrans.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngwio.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngwrite.c View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngwtran.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/fx_lpng/src/fx_pngwutil.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A samples/image_diff.cc View 1 2 1 chunk +398 lines, -0 lines 0 comments Download
A samples/image_diff_png.h View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A samples/image_diff_png.cc View 1 2 1 chunk +644 lines, -0 lines 0 comments Download
M samples/pdfium_test.cc View 1 2 7 chunks +60 lines, -3 lines 0 comments Download
M samples/samples.gyp View 1 2 2 chunks +57 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
John, please review.
5 years, 10 months ago (2015-02-23 23:41:56 UTC) #2
jam
rubberstamp lgtm
5 years, 10 months ago (2015-02-23 23:58:37 UTC) #3
Tom Sepez
5 years, 10 months ago (2015-02-24 00:00:02 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
ef1e85caf492e1b9bf9803647d3c5db1abea77c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698