extensions/browser/api/networking_config/networking_config_api.cc - Issue 950023005: [Extensions] Apply WARN_UNUSED_RESULT and final keyword to ExtensionFunctions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_api.cc

Issue 950023005: [Extensions] Apply WARN_UNUSED_RESULT and final keyword to ExtensionFunctions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromeos api Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/networking_config/networking_config_api.cc

diff --git a/extensions/browser/api/networking_config/networking_config_api.cc b/extensions/browser/api/networking_config/networking_config_api.cc

index bf3743665d8b3a4d8de58682319dd2992350a020..19b69eef2b69906e6185adb66069e770da99279a 100644

--- a/extensions/browser/api/networking_config/networking_config_api.cc

+++ b/extensions/browser/api/networking_config/networking_config_api.cc

@@ -89,7 +89,7 @@ NetworkingConfigFinishAuthenticationFunction::Run() {

service->GetAuthenticationResult();

if (last_result.authentication_state != NetworkingConfigService::NOTRY ||

last_result.guid != parameters_->guid) {

- RespondNow(Error(kAuthenticationResultFailed));

+ return RespondNow(Error(kAuthenticationResultFailed));

}

// Populate NetworkingCaptivePortalAPI::AuthenticationResult.

« no previous file with comments | « chrome/browser/extensions/chrome_extension_function.h ('k') | extensions/browser/extension_function.h » ('j') | no next file with comments »